Issue 2658693002: Removed usage of std::map and std::vector from kernel code. Issue #28064.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2658693002: Removed usage of std::map and std::vector from kernel code. Issue #28064. (Closed)

Created:
3 years, 11 months ago by bkonyi

Modified:
3 years, 11 months ago

Reviewers:
zra, Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -29 lines)			Patch
M	runtime/vm/kernel_binary.cc	View		4 chunks	+29 lines, -24 lines	0 comments	Download
M	runtime/vm/kernel_reader.h	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/kernel_to_il.h	View		1 chunk	+34 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

bkonyi

This is a resubmit of this change: https://codereview.chromium.org/2655463005/. After the revert, I somehow managed to ...

3 years, 11 months ago (2017-01-25 22:37:44 UTC) #2

bkonyi

3 years, 11 months ago (2017-01-25 22:53:43 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
0d9a7970f50d0f41e8e1e3b03a6fd09ae90d1739 (presubmit successful).