device/vr/test/fake_vr_device.h - Issue 2658643003: Refactor GvrDelegate ownership into GvrDelegateProvider and fix more threading violations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/vr/test/fake_vr_device.h

Issue 2658643003: Refactor GvrDelegate ownership into GvrDelegateProvider and fix more threading violations. (Closed)

Patch Set: Address comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/vr/test/fake_vr_device.h

diff --git a/device/vr/test/fake_vr_device.h b/device/vr/test/fake_vr_device.h

index 188d82e7dce4b1fcb6a5c3838512890811568bca..178610eaacccb3238c582e93013b4402d0da1806 100644

--- a/device/vr/test/fake_vr_device.h

+++ b/device/vr/test/fake_vr_device.h

@@ -22,7 +22,9 @@ class FakeVRDevice : public VRDevice {

void SetVRDevice(const mojom::VRDisplayInfoPtr& device);

- mojom::VRDisplayInfoPtr GetVRDevice() override;

+ // VRDevice

+ void GetVRDevice(

+ const base::Callback<void(mojom::VRDisplayInfoPtr)>& callback) override;

void ResetPose() override;

void RequestPresent(const base::Callback<void(bool)>& callback) override;

« no previous file with comments | « device/vr/android/gvr/gvr_gamepad_data_fetcher.cc ('k') | device/vr/test/fake_vr_device.cc » ('j') | no next file with comments »