Refactor GvrDelegate ownership into GvrDelegateProvider and fix more threading violations.

chrome/browser/android/vr_shell/non_presenting_gvr_delegate.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/vr_shell/non_presenting_gvr_delegate.h"
 
 #include "chrome/browser/android/vr_shell/vr_shell.h"
+#include "third_party/gvr-android-sdk/src/libraries/headers/vr/gvr/capi/include/gvr.h"
 
 namespace vr_shell {
 
 namespace {
 static constexpr long kPredictionTimeWithoutVsyncNanos = 50000000;
 }  // namespace
 
-NonPresentingGvrDelegate::NonPresentingGvrDelegate(long context)
+NonPresentingGvrDelegate::NonPresentingGvrDelegate(gvr_context* context)
     : task_runner_(base::ThreadTaskRunnerHandle::Get()),
       binding_(this),
       weak_ptr_factory_(this) {
-  gvr_api_ = gvr::GvrApi::WrapNonOwned(reinterpret_cast<gvr_context*>(context));
+  gvr_api_ = gvr::GvrApi::WrapNonOwned(context);
 }
 
 NonPresentingGvrDelegate::~NonPresentingGvrDelegate() {
   StopVSyncLoop();
 }
 
-gvr::Sizei NonPresentingGvrDelegate::GetWebVRCompositorSurfaceSize() {
-   return device::kInvalidRenderTargetSize;
-}
-
-gvr::GvrApi* NonPresentingGvrDelegate::gvr_api() {
-  return gvr_api_.get();
-}
-
 void NonPresentingGvrDelegate::OnVRVsyncProviderRequest(
     device::mojom::VRVSyncProviderRequest request) {
   binding_.Close();
   binding_.Bind(std::move(request));
   binding_.set_connection_error_handler(
       base::Bind(&NonPresentingGvrDelegate::StopVSyncLoop,
                  weak_ptr_factory_.GetWeakPtr()));
   StartVSyncLoop();
 }
 
@@ skipping 93 matching lines @@
 void NonPresentingGvrDelegate::SendVSync(base::TimeDelta time,
                                          const GetVSyncCallback& callback) {
   gvr::ClockTimePoint target_time = gvr::GvrApi::GetTimePointNow();
   target_time.monotonic_system_time_nanos += kPredictionTimeWithoutVsyncNanos;
 
   gvr::Mat4f head_mat = gvr_api_->ApplyNeckModel(
       gvr_api_->GetHeadSpaceFromStartSpaceRotation(target_time), 1.0f);
   callback.Run(VrShell::VRPosePtrFromGvrPose(head_mat), time, -1);
 }
 
+bool NonPresentingGvrDelegate::SupportsPresentation() {
+  return false;
+}
+
+void NonPresentingGvrDelegate::ResetPose() {
+  // Should never call RecenterTracking when using with Daydream viewers. On
+  // those devices recentering should only be done via the controller.
+  if (gvr_api_ && gvr_api_->GetViewerType() == GVR_VIEWER_TYPE_CARDBOARD)
+    gvr_api_->RecenterTracking();
+}
+
+void NonPresentingGvrDelegate::CreateVRDisplayInfo(
+    const base::Callback<void(device::mojom::VRDisplayInfoPtr)>& callback,
+    uint32_t device_id) {
+  callback.Run(VrShell::CreateVRDisplayInfo(
+      gvr_api_.get(), device::kInvalidRenderTargetSize, device_id));
+}
+
 }  // namespace vr_shell