src/builtins/x64/builtins-x64.cc - Issue 2658573008: Convert the array iterator protector to a PropertyCell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins/x64/builtins-x64.cc

Issue 2658573008: Convert the array iterator protector to a PropertyCell. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins/x64/builtins-x64.cc

diff --git a/src/builtins/x64/builtins-x64.cc b/src/builtins/x64/builtins-x64.cc

index 8ec2efecf1ac3c61fe09f38ce14a4f5494969526..34c93363429d9063a02bde73c78a70328748ae50 100644

--- a/src/builtins/x64/builtins-x64.cc

+++ b/src/builtins/x64/builtins-x64.cc

@@ -2849,7 +2849,7 @@ static void CheckSpreadAndPushToStack(MacroAssembler* masm) {

// Check that the ArrayPrototype hasn't been modified in a way that would

// affect iteration.

__ LoadRoot(rcx, Heap::kArrayIteratorProtectorRootIndex);

- __ Cmp(FieldOperand(rcx, Cell::kValueOffset),

+ __ Cmp(FieldOperand(rcx, PropertyCell::kValueOffset),

Smi::FromInt(Isolate::kProtectorValid));

__ j(not_equal, &runtime_call);

« no previous file with comments | « src/builtins/s390/builtins-s390.cc ('k') | src/builtins/x87/builtins-x87.cc » ('j') | no next file with comments »