Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Unified Diff: sync/engine/get_commit_ids.cc

Issue 265853004: Revert of Keep track of which attachments are referenced by which sync entries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/api/sync_data.cc ('k') | sync/internal_api/base_node.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/engine/get_commit_ids.cc
diff --git a/sync/engine/get_commit_ids.cc b/sync/engine/get_commit_ids.cc
index 5f91915d5a0720e018ea333938e1329727c85cc4..80222ee20dd625d7efe108195695224d0c5569a6 100644
--- a/sync/engine/get_commit_ids.cc
+++ b/sync/engine/get_commit_ids.cc
@@ -108,13 +108,9 @@
// Return true if this entry has any attachments that haven't yet been uploaded
// to the server.
bool HasAttachmentNotOnServer(const syncable::Entry& entry) {
- // TODO(maniscalco): Add test case (bug 356266).
- const sync_pb::AttachmentMetadata& metadata = entry.GetAttachmentMetadata();
- for (int i = 0; i < metadata.record_size(); ++i) {
- if (!metadata.record(i).is_on_server()) {
- return true;
- }
- }
+ // TODO(maniscalco): Once AttachmentMetadata is fleshed out, implement this
+ // function to return true if any of the attachments haven't been uploaded to
+ // the server. Add test case (bug 356266).
return false;
}
« no previous file with comments | « sync/api/sync_data.cc ('k') | sync/internal_api/base_node.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698