Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: sync/internal_api/base_node.cc

Issue 265853004: Revert of Keep track of which attachments are referenced by which sync entries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sync/engine/get_commit_ids.cc ('k') | sync/internal_api/public/base/attachment_id_proto.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/internal_api/public/base_node.h" 5 #include "sync/internal_api/public/base_node.h"
6 6
7 #include <stack> 7 #include <stack>
8 8
9 #include "base/strings/string_number_conversions.h" 9 #include "base/strings/string_number_conversions.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 273 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 284
285 const sync_pb::EntitySpecifics& BaseNode::GetEntitySpecifics() const { 285 const sync_pb::EntitySpecifics& BaseNode::GetEntitySpecifics() const {
286 return GetUnencryptedSpecifics(GetEntry()); 286 return GetUnencryptedSpecifics(GetEntry());
287 } 287 }
288 288
289 ModelType BaseNode::GetModelType() const { 289 ModelType BaseNode::GetModelType() const {
290 return GetEntry()->GetModelType(); 290 return GetEntry()->GetModelType();
291 } 291 }
292 292
293 const syncer::AttachmentIdList BaseNode::GetAttachmentIds() const { 293 const syncer::AttachmentIdList BaseNode::GetAttachmentIds() const {
294 AttachmentIdList result; 294 // TODO(maniscalco): Once EntryKernel is capable of storing AttachmentIds,
295 const sync_pb::AttachmentMetadata& metadata = 295 // update this method to retrieve the list of AttachmentIds from read_node and
296 GetEntry()->GetAttachmentMetadata(); 296 // pass it to CreateRemoteData (bug 348625).
297 for (int i = 0; i < metadata.record_size(); ++i) { 297 return AttachmentIdList();
298 result.push_back(AttachmentId::CreateFromProto(metadata.record(i).id()));
299 }
300 return result;
301 } 298 }
302 299
303 void BaseNode::SetUnencryptedSpecifics( 300 void BaseNode::SetUnencryptedSpecifics(
304 const sync_pb::EntitySpecifics& specifics) { 301 const sync_pb::EntitySpecifics& specifics) {
305 ModelType type = GetModelTypeFromSpecifics(specifics); 302 ModelType type = GetModelTypeFromSpecifics(specifics);
306 DCHECK_NE(UNSPECIFIED, type); 303 DCHECK_NE(UNSPECIFIED, type);
307 if (GetModelType() != UNSPECIFIED) { 304 if (GetModelType() != UNSPECIFIED) {
308 DCHECK_EQ(GetModelType(), type); 305 DCHECK_EQ(GetModelType(), type);
309 } 306 }
310 unencrypted_data_.CopyFrom(specifics); 307 unencrypted_data_.CopyFrom(specifics);
311 } 308 }
312 309
313 } // namespace syncer 310 } // namespace syncer
OLDNEW
« no previous file with comments | « sync/engine/get_commit_ids.cc ('k') | sync/internal_api/public/base/attachment_id_proto.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698