Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp

Issue 2658513002: sdf
Patch Set: sdf Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
index 9044809a6cadfe204b54ea17116d1e9748b7ef41..9f42ce1cda0090c02284a961115d45b1e241e0f3 100644
--- a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
+++ b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
@@ -743,42 +743,26 @@ TEST_F(PaintArtifactCompositorTestWithPropertyTrees, NestedScrollNodes) {
const cc::ScrollTree& scrollTree = propertyTrees().scroll_tree;
// Node #0 reserved for null; #1 for root render surface.
- ASSERT_EQ(4u, scrollTree.size());
- const cc::ScrollNode& scrollNodeA = *scrollTree.Node(2);
- EXPECT_EQ(gfx::Size(2, 3), scrollNodeA.scroll_clip_layer_bounds);
- EXPECT_EQ(gfx::Size(5, 7), scrollNodeA.bounds);
- EXPECT_FALSE(scrollNodeA.user_scrollable_horizontal);
- EXPECT_TRUE(scrollNodeA.user_scrollable_vertical);
- EXPECT_EQ(1, scrollNodeA.parent_id);
- const cc::ScrollNode& scrollNodeB = *scrollTree.Node(3);
- EXPECT_EQ(gfx::Size(19, 23), scrollNodeB.scroll_clip_layer_bounds);
- EXPECT_EQ(gfx::Size(29, 31), scrollNodeB.bounds);
- EXPECT_TRUE(scrollNodeB.user_scrollable_horizontal);
- EXPECT_FALSE(scrollNodeB.user_scrollable_vertical);
- EXPECT_EQ(scrollNodeA.id, scrollNodeB.parent_id);
- EXPECT_EQ(expectedCompositorElementIdA, scrollNodeA.element_id);
- EXPECT_EQ(scrollNodeA.id,
+ ASSERT_EQ(3u, scrollTree.size());
+ const cc::ScrollNode& scrollNode = *scrollTree.Node(2);
+ EXPECT_EQ(gfx::Size(2, 3), scrollNode.scroll_clip_layer_bounds);
+ EXPECT_EQ(gfx::Size(5, 7), scrollNode.bounds);
+ EXPECT_FALSE(scrollNode.user_scrollable_horizontal);
+ EXPECT_TRUE(scrollNode.user_scrollable_vertical);
+ EXPECT_EQ(1, scrollNode.parent_id);
+ EXPECT_EQ(expectedCompositorElementIdA, scrollNode.element_id);
+ EXPECT_EQ(scrollNode.id,
elementIdToScrollNodeIndex(expectedCompositorElementIdA));
- EXPECT_EQ(expectedCompositorElementIdB, scrollNodeB.element_id);
- EXPECT_EQ(scrollNodeB.id,
- elementIdToScrollNodeIndex(expectedCompositorElementIdB));
EXPECT_EQ(expectedCompositorElementIdA, contentLayerAt(0)->element_id());
- EXPECT_EQ(expectedCompositorElementIdB, contentLayerAt(1)->element_id());
const cc::TransformTree& transformTree = propertyTrees().transform_tree;
const cc::TransformNode& transformNodeA =
- *transformTree.Node(scrollNodeA.transform_id);
+ *transformTree.Node(scrollNode.transform_id);
EXPECT_TRUE(transformNodeA.local.IsIdentity());
EXPECT_EQ(gfx::ScrollOffset(-11, -13), transformNodeA.scroll_offset);
- const cc::TransformNode& transformNodeB =
- *transformTree.Node(scrollNodeB.transform_id);
- EXPECT_EQ(gfx::ScrollOffset(-37, -41), transformNodeB.scroll_offset);
-
- EXPECT_TRUE(scrollNodeA.main_thread_scrolling_reasons &
+ EXPECT_TRUE(scrollNode.main_thread_scrolling_reasons &
MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects);
- EXPECT_FALSE(scrollNodeB.main_thread_scrolling_reasons &
- MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects);
}
TEST_F(PaintArtifactCompositorTestWithPropertyTrees, MergeSimpleChunks) {

Powered by Google App Engine
This is Rietveld 408576698