Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Issue 2658483002: Fix summary handling of invalid annotations of the form `@a.b.c`. (Closed)

Created:
3 years, 11 months ago by Paul Berry
Modified:
3 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -29 lines) Patch
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 1 chunk +11 lines, -11 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_driver_test.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 2 chunks +40 lines, -11 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 11 months ago (2017-01-24 20:04:55 UTC) #2
scheglov
lgtm https://codereview.chromium.org/2658483002/diff/1/pkg/analyzer/test/src/summary/resynthesize_common.dart File pkg/analyzer/test/src/summary/resynthesize_common.dart (right): https://codereview.chromium.org/2658483002/diff/1/pkg/analyzer/test/src/summary/resynthesize_common.dart#newcode3769 pkg/analyzer/test/src/summary/resynthesize_common.dart:3769: test_invalid_annotation_prefixed_constructor() { Can we also add tests for ...
3 years, 11 months ago (2017-01-24 20:10:18 UTC) #3
Paul Berry
On 2017/01/24 20:10:18, scheglov wrote: > lgtm > > https://codereview.chromium.org/2658483002/diff/1/pkg/analyzer/test/src/summary/resynthesize_common.dart > File pkg/analyzer/test/src/summary/resynthesize_common.dart (right): > ...
3 years, 11 months ago (2017-01-24 21:17:37 UTC) #4
Paul Berry
3 years, 11 months ago (2017-01-24 21:31:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7284ab5be217a42820c0c1ca8b7e08cb8436b309 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698