Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: chrome/browser/bookmarks/enhanced_bookmarks_features.cc

Issue 265843009: Restored an option to enable enhanced bookmarks experiment from Finch (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/enhanced_bookmarks_features.cc
diff --git a/chrome/browser/bookmarks/enhanced_bookmarks_features.cc b/chrome/browser/bookmarks/enhanced_bookmarks_features.cc
index e18f18f7dbe637a817560ef643d0c8dd6d4e1176..c6453e33f9e143586c62588cfdaf794f82464786 100644
--- a/chrome/browser/bookmarks/enhanced_bookmarks_features.cc
+++ b/chrome/browser/bookmarks/enhanced_bookmarks_features.cc
@@ -43,6 +43,12 @@ void UpdateBookmarksExperiment(
base::StringValue(switches::kManualEnhancedBookmarks), &index);
experiments_list->AppendIfNotPresent(
new base::StringValue(switches::kManualEnhancedBookmarksOptout));
+ } else if (bookmarks_experiment_state ==
+ kBookmarksExperimentEnabledFromFinch) {
+ experiments_list->Remove(
+ base::StringValue(switches::kManualEnhancedBookmarks), &index);
+ experiments_list->Remove(
+ base::StringValue(switches::kManualEnhancedBookmarksOptout), &index);
}
}
@@ -53,6 +59,10 @@ bool IsEnhancedBookmarksExperimentEnabled() {
return true;
}
+ return IsEnhancedBookmarksExperimentEnabledFromFinch();
+}
+
+bool IsEnhancedBookmarksExperimentEnabledFromFinch() {
std::string ext_id = GetEnhancedBookmarksExtensionIdFromFinch();
extensions::FeatureProvider* feature_provider =
extensions::FeatureProvider::GetPermissionFeatures();

Powered by Google App Engine
This is Rietveld 408576698