Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Side by Side Diff: chrome/browser/bookmarks/enhanced_bookmarks_features.h

Issue 265843009: Restored an option to enable enhanced bookmarks experiment from Finch (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: one more unit test fix Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/bookmarks/enhanced_bookmarks_features.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BOOKMARKS_ENHANCED_BOOKMARKS_FEATURES_H_ 5 #ifndef CHROME_BROWSER_BOOKMARKS_ENHANCED_BOOKMARKS_FEATURES_H_
6 #define CHROME_BROWSER_BOOKMARKS_ENHANCED_BOOKMARKS_FEATURES_H_ 6 #define CHROME_BROWSER_BOOKMARKS_ENHANCED_BOOKMARKS_FEATURES_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "extensions/common/extension.h" 10 #include "extensions/common/extension.h"
11 11
12 class PrefService; 12 class PrefService;
13 13
14 // States for bookmark experiment. They are set by Chrome sync into
15 // sync_driver::prefs::kEnhancedBookmarksExperimentEnabled user preference and
16 // used for UMA reporting as well.
14 enum BookmarksExperimentState { 17 enum BookmarksExperimentState {
15 kNoBookmarksExperiment, 18 kNoBookmarksExperiment,
16 kBookmarksExperimentEnabled, 19 kBookmarksExperimentEnabled,
17 kBookmarksExperimentEnabledUserOptOut 20 kBookmarksExperimentEnabledUserOptOut,
21 kBookmarksExperimentEnabledFromFinch,
22 kBookmarksExperimentOptOutFromFinch,
23 kBookmarksExperimentEnabledFromFinchUserSignedIn,
24 kBookmarksExperimentEnumSize
18 }; 25 };
19 26
27 // Returns true and sets |extension_id| if bookmarks experiment enabled
28 // false if no bookmark experiment or extension id is empty.
29 bool GetBookmarksExperimentExtensionID(const PrefService* user_prefs,
30 std::string* extension_id);
31
32 // Updates bookmark experiment state based on information from Chrome sync
33 // and Finch experiments.
34 void UpdateBookmarksExperimentState(const PrefService* user_prefs,
35 PrefService* local_state,
36 bool user_signed_in);
37
20 // Sets flag to opt-in user into Finch experiment. 38 // Sets flag to opt-in user into Finch experiment.
21 void UpdateBookmarksExperiment( 39 void ForceFinchBookmarkExperimentIfNeeded(
22 PrefService* local_state, 40 PrefService* local_state,
23 BookmarksExperimentState bookmarks_experiment_state); 41 BookmarksExperimentState bookmarks_experiment_state);
24 42
25 // Returns true if enhanced bookmarks experiment is enabled. 43 // Returns true if enhanced bookmarks experiment is enabled.
44 // Experiment could be enable from Chrome sync or from Finch.
26 bool IsEnhancedBookmarksExperimentEnabled(); 45 bool IsEnhancedBookmarksExperimentEnabled();
27 46
28 // Returns true when flag enable-dom-distiller is set or enabled from Finch. 47 // Returns true when flag enable-dom-distiller is set or enabled from Finch.
29 bool IsEnableDomDistillerSet(); 48 bool IsEnableDomDistillerSet();
30 49
31 // Returns true when flag enable-sync-articles is set or enabled from Finch. 50 // Returns true when flag enable-sync-articles is set or enabled from Finch.
32 bool IsEnableSyncArticlesSet(); 51 bool IsEnableSyncArticlesSet();
33 52
34 // Get extension id from Finch EnhancedBookmarks group parameters.
35 std::string GetEnhancedBookmarksExtensionIdFromFinch();
36
37 #endif // CHROME_BROWSER_BOOKMARKS_ENHANCED_BOOKMARKS_FEATURES_H_ 53 #endif // CHROME_BROWSER_BOOKMARKS_ENHANCED_BOOKMARKS_FEATURES_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/bookmarks/enhanced_bookmarks_features.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698