Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js

Issue 2658383002: [DevTools] Make UI.GlassPane position contentElement for different overlay controls. (Closed)
Patch Set: rebased Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js b/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
index 80c23c5188c3560f7380ba53253a005d99f17d14..121478bf95565792d96d54cff2dc32dceaa4c9c3 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
@@ -123,8 +123,9 @@ UI.Toolbar = class {
var document = button.element.ownerDocument;
document.documentElement.addEventListener('mouseup', mouseUp, false);
- var optionsGlassPane = new UI.GlassPane(document);
- var optionsBar = new UI.Toolbar('fill', optionsGlassPane.element);
+ var optionsGlassPane = new UI.GlassPane(document, false /* dimmed */, true /* blockPointerEvents */, event => {});
+ optionsGlassPane.show();
+ var optionsBar = new UI.Toolbar('fill', optionsGlassPane.contentElement);
optionsBar._contentElement.classList.add('floating');
const buttonHeight = 26;
@@ -167,7 +168,7 @@ UI.Toolbar = class {
function mouseUp(e) {
if (e.which !== 1)
return;
- optionsGlassPane.dispose();
+ optionsGlassPane.hide();
document.documentElement.removeEventListener('mouseup', mouseUp, false);
for (var i = 0; i < buttons.length; ++i) {

Powered by Google App Engine
This is Rietveld 408576698