third_party/WebKit/Source/devtools/front_end/ui/Popover.js - Issue 2658383002: [DevTools] Make UI.GlassPane position contentElement for different overlay controls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/Popover.js

Issue 2658383002: [DevTools] Make UI.GlassPane position contentElement for different overlay controls. (Closed)

Patch Set: rebased Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/ui/Popover.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Popover.js b/third_party/WebKit/Source/devtools/front_end/ui/Popover.js

index 7953b7a6cab4ad7a61da739cf6053520dcb58c6a..375a9c0d1311d30accc82276b3c2711890a99489 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/Popover.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/Popover.js

@@ -165,7 +165,7 @@ UI.Popover = class extends UI.Widget {

// Skinny tooltips are not pretty, their arrow location is not nice.

preferredWidth = Math.max(preferredWidth, 50);

// Position relative to main DevTools element.

- const container = UI.Dialog.modalHostView().element;

+ const container = UI.GlassPane.container(/** @type {!Document} */ (this._containerElement.ownerDocument));

const totalWidth = container.offsetWidth;

const totalHeight = container.offsetHeight;