Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: third_party/WebKit/Source/core/animation/LengthInterpolationFunctions.cpp

Issue 2658333003: Add smooth interpolation support for <length> custom properties (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/LengthInterpolationFunctions.cpp
diff --git a/third_party/WebKit/Source/core/animation/LengthInterpolationFunctions.cpp b/third_party/WebKit/Source/core/animation/LengthInterpolationFunctions.cpp
index f4bf99ba0e6a1e1c8bc001568efb0236ca8d8510..1553826ba2d5f5a7a0f53dbfc341d5d5ba94a064 100644
--- a/third_party/WebKit/Source/core/animation/LengthInterpolationFunctions.cpp
+++ b/third_party/WebKit/Source/core/animation/LengthInterpolationFunctions.cpp
@@ -4,6 +4,7 @@
#include "core/animation/LengthInterpolationFunctions.h"
+#include "core/css/CSSCalculationValue.h"
#include "core/css/CSSPrimitiveValue.h"
#include "core/css/CSSToLengthConversionData.h"
#include "platform/CalculationValue.h"
@@ -159,6 +160,11 @@ static double clampToRange(double x, ValueRange range) {
return (range == ValueRangeNonNegative && x < 0) ? 0 : x;
}
+CSSPrimitiveValue::UnitType indexToUnitType(size_t index) {
+ return CSSPrimitiveValue::lengthUnitTypeToUnitType(
+ static_cast<CSSPrimitiveValue::LengthUnitType>(index));
+}
+
Length LengthInterpolationFunctions::createLength(
const InterpolableValue& interpolableValue,
const NonInterpolableValue* nonInterpolableValue,
@@ -177,10 +183,7 @@ Length LengthInterpolationFunctions::createLength(
if (i == CSSPrimitiveValue::UnitTypePercentage) {
percentage = value;
} else {
- CSSPrimitiveValue::UnitType type =
- CSSPrimitiveValue::lengthUnitTypeToUnitType(
- static_cast<CSSPrimitiveValue::LengthUnitType>(i));
- pixels += conversionData.zoomedComputedPixels(value, type);
+ pixels += conversionData.zoomedComputedPixels(value, indexToUnitType(i));
}
}
@@ -196,4 +199,48 @@ Length LengthInterpolationFunctions::createLength(
Fixed);
}
+const CSSValue* LengthInterpolationFunctions::createCSSValue(
+ const InterpolableValue& interpolableValue,
+ const NonInterpolableValue* nonInterpolableValue,
+ ValueRange range) {
+ const InterpolableList& interpolableList =
+ toInterpolableList(interpolableValue);
+ bool hasPercentage =
+ CSSLengthNonInterpolableValue::hasPercentage(nonInterpolableValue);
+
+ CSSCalcExpressionNode* rootNode = nullptr;
+ CSSPrimitiveValue* firstValue = nullptr;
+
+ for (size_t i = 0; i < CSSPrimitiveValue::LengthUnitTypeCount; i++) {
+ double value = toInterpolableNumber(*interpolableList.get(i)).value();
+ if (value == 0 ||
+ (i == CSSPrimitiveValue::UnitTypePercentage && !hasPercentage)) {
+ continue;
+ }
+ CSSPrimitiveValue* currentValue =
+ CSSPrimitiveValue::create(value, indexToUnitType(i));
+
+ if (!firstValue) {
+ DCHECK(!rootNode);
+ firstValue = currentValue;
+ continue;
+ }
+ CSSCalcExpressionNode* currentNode =
+ CSSCalcValue::createExpressionNode(currentValue);
+ if (!rootNode) {
+ rootNode = CSSCalcValue::createExpressionNode(firstValue);
+ }
+ rootNode =
+ CSSCalcValue::createExpressionNode(rootNode, currentNode, CalcAdd);
+ }
+
+ if (rootNode) {
+ return CSSPrimitiveValue::create(CSSCalcValue::create(rootNode));
+ }
+ if (firstValue) {
+ return firstValue;
+ }
+ return CSSPrimitiveValue::create(0, CSSPrimitiveValue::UnitType::Pixels);
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698