Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 265833008: Fix for bug 18596- analyzer warning in dart:html under Dartium (Closed)

Created:
6 years, 7 months ago by blois
Modified:
6 years, 7 months ago
Reviewers:
Leaf, Emily Fortuna
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Fix for bug 18596- analyzer warning in dart:html under Dartium BUG=18596 R=leafp@google.com Committed: https://code.google.com/p/dart/source/detail?r=35671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/src/dartium_CustomElementSupport.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
blois
6 years, 7 months ago (2014-05-01 23:37:04 UTC) #1
Leaf
lgtm
6 years, 7 months ago (2014-05-01 23:45:37 UTC) #2
blois
Committed patchset #1 manually as r35671 (presubmit successful).
6 years, 7 months ago (2014-05-01 23:52:24 UTC) #3
Emily Fortuna
6 years, 7 months ago (2014-05-02 00:36:04 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698