drive: Stop checking free disk space in ResourceMetadata::Initialize

drive: Stop checking free disk space in ResourceMetadata::Initialize

Instead, perform stricter error checks.

Stop calling EnoughDiskSpaceIsAvailableForDBOperation() in ResourceMetadata::Initialize().
To distinguish serious failures from not-found cases, change the return type of  ResourceMetadataStorage's methods to FileError.

BUG=319410
TEST=unit_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269541

[hashimoto, 2014-05-08 07:58:49]

Please review.
Some methods of FileCache and ResourceMetadata are still ignoring errors as
changing the return type of these methods may result in an extremely big patch
size.

https://codereview.chromium.org/265833003/diff/60002/chrome/browser/chromeos/...
File chrome/browser/chromeos/drive/resource_metadata.cc (right):

https://codereview.chromium.org/265833003/diff/60002/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/resource_metadata.cc:68: FileError
ResourceMetadata::Initialize() {
This method is the only method which is expected to change behavior.

https://codereview.chromium.org/265833003/diff/60002/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/resource_metadata.cc:249: if (local_id.empty())
Retry was omitted as it may become complicated.

[kinaba, 2014-05-09 01:57:28]

lgtm

https://codereview.chromium.org/265833003/diff/60002/chrome/browser/chromeos/...
File chrome/browser/chromeos/drive/resource_metadata.cc (right):

https://codereview.chromium.org/265833003/diff/60002/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/resource_metadata.cc:241: else if (error !=
FILE_ERROR_NOT_FOUND)
maybe:

error = GetId()
if(OK)
  error = GetEntry()

if (OK)
  return EXISTS;
elif(!= NOT_FOUND)
  return error;

to merge two not NOT_FOUND branches.

https://codereview.chromium.org/265833003/diff/60002/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/resource_metadata.cc:249: if (local_id.empty())
On 2014/05/08 07:58:49, hashimoto wrote:
> Retry was omitted as it may become complicated.

Sounds good, but could you leave a comment that the omit is intentional?

[hashimoto, 2014-05-09 05:04:31]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-05-09 05:09:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/265833003/60002

[hashimoto, 2014-05-09 05:21:49]

The CQ bit was unchecked by hashimoto@chromium.org

[hashimoto, 2014-05-09 05:28:47]

https://codereview.chromium.org/265833003/diff/60002/chrome/browser/chromeos/...
File chrome/browser/chromeos/drive/resource_metadata.cc (right):

https://codereview.chromium.org/265833003/diff/60002/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/resource_metadata.cc:241: else if (error !=
FILE_ERROR_NOT_FOUND)
On 2014/05/09 01:57:28, kinaba wrote:
> maybe:
> 
> error = GetId()
> if(OK)
>   error = GetEntry()
> 
> if (OK)
>   return EXISTS;
> elif(!= NOT_FOUND)
>   return error;
> 
> to merge two not NOT_FOUND branches.

Thanks, it looks simpler.
Done.

https://codereview.chromium.org/265833003/diff/60002/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/resource_metadata.cc:249: if (local_id.empty())
On 2014/05/09 01:57:28, kinaba wrote:
> On 2014/05/08 07:58:49, hashimoto wrote:
> > Retry was omitted as it may become complicated.
> 
> Sounds good, but could you leave a comment that the omit is intentional?

Done.

[kinaba, 2014-05-09 05:31:26]

lgtm

https://codereview.chromium.org/265833003/diff/100001/chrome/browser/chromeos...
File chrome/browser/chromeos/drive/resource_metadata.cc (right):

https://codereview.chromium.org/265833003/diff/100001/chrome/browser/chromeos...
chrome/browser/chromeos/drive/resource_metadata.cc:247: // We don't check for ID
collisions as its probability is extemely low.
nit: ext[r]emely

[hashimoto, 2014-05-09 05:34:41]

https://codereview.chromium.org/265833003/diff/100001/chrome/browser/chromeos...
File chrome/browser/chromeos/drive/resource_metadata.cc (right):

https://codereview.chromium.org/265833003/diff/100001/chrome/browser/chromeos...
chrome/browser/chromeos/drive/resource_metadata.cc:247: // We don't check for ID
collisions as its probability is extemely low.
On 2014/05/09 05:31:26, kinaba wrote:
> nit: ext[r]emely

Oops, done.

[hashimoto, 2014-05-09 05:34:44]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-05-09 05:36:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/265833003/120001

[commit-bot: I haz the power, 2014-05-10 06:19:54]

Change committed as 269541

[hashimoto, 2014-05-12 02:28:12]

On 2014/05/10 06:19:54, I haz the power (commit-bot) wrote:
> Change committed as 269541

BUG number was wrong.
The correct number is 263064.