Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2658303002: Relax type bound restrictions slightly, apply to typedefs. (Closed)

Created:
3 years, 10 months ago by Leaf
Modified:
3 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Relax type bound restrictions slightly, apply to typedefs. This relaxes the restriction on raw types in bounds slightly, to allow parameterized types in bounds to be used without type arguments if their bounds are empty. This CL also fixes the error check for raw types in type bounds to apply to typedefs as well. BUG= R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/a6138dad2aeb247d6c002c43466f7f10afdbcf53

Patch Set 1 #

Patch Set 2 : Typing fix #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -16 lines) Patch
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 1 chunk +7 lines, -3 lines 2 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 1 6 chunks +57 lines, -11 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Leaf
https://codereview.chromium.org/2658303002/diff/20001/pkg/analyzer/lib/src/generated/error_verifier.dart File pkg/analyzer/lib/src/generated/error_verifier.dart (right): https://codereview.chromium.org/2658303002/diff/20001/pkg/analyzer/lib/src/generated/error_verifier.dart#newcode5242 pkg/analyzer/lib/src/generated/error_verifier.dart:5242: if (type is ParameterizedType) { This change is to ...
3 years, 10 months ago (2017-01-27 23:24:06 UTC) #2
scheglov
LGTM
3 years, 10 months ago (2017-01-28 01:17:51 UTC) #3
Leaf
3 years, 10 months ago (2017-01-28 02:05:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a6138dad2aeb247d6c002c43466f7f10afdbcf53 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698