Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: sync/internal_api/sync_manager_factory.cc

Issue 265823009: Let SyncManagerFactory create different types of sync managers according to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/sync_manager_factory.cc
diff --git a/sync/internal_api/sync_manager_factory.cc b/sync/internal_api/sync_manager_factory.cc
index 9d784b46ada76cb50d03ace2cf040cdd00a14f2e..81e05c9198a8f04152cdea7163f4183137024023 100644
--- a/sync/internal_api/sync_manager_factory.cc
+++ b/sync/internal_api/sync_manager_factory.cc
@@ -4,11 +4,14 @@
#include "sync/internal_api/public/sync_manager_factory.h"
+#include "sync/internal_api/sync_backup_manager.h"
#include "sync/internal_api/sync_manager_impl.h"
+#include "sync/internal_api/sync_rollback_manager.h"
namespace syncer {
-SyncManagerFactory::SyncManagerFactory() {
+SyncManagerFactory::SyncManagerFactory(SyncManagerFactory::MANAGER_TYPE type)
+ : type_(type) {
}
SyncManagerFactory::~SyncManagerFactory() {
@@ -16,7 +19,16 @@ SyncManagerFactory::~SyncManagerFactory() {
scoped_ptr<SyncManager> SyncManagerFactory::CreateSyncManager(
const std::string name) {
- return scoped_ptr<SyncManager>(new SyncManagerImpl(name));
+ switch (type_) {
+ case NORMAL:
+ return scoped_ptr<SyncManager>(new SyncManagerImpl(name));
+ case BACKUP:
+ return scoped_ptr<SyncManager>(new SyncBackupManager);
Nicolas Zea 2014/05/13 17:49:15 nit: prefer explicitly noting that this is being d
haitaol1 2014/05/13 18:10:59 Done.
+ case ROLLBACK:
+ return scoped_ptr<SyncManager>(new SyncRollbackManager);
+ default:
+ NOTREACHED();
+ }
}
} // namespace syncer

Powered by Google App Engine
This is Rietveld 408576698