Let SyncManagerFactory create different types of sync managers according to

Let SyncManagerFactory create different types of sync managers according to
constructor param.

BUG=362679
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270576

[Nicolas Zea, 2014-05-13 17:49:14]

lgtm

https://codereview.chromium.org/265823009/diff/1/sync/internal_api/public/syn...
File sync/internal_api/public/sync_manager_factory.h (right):

https://codereview.chromium.org/265823009/diff/1/sync/internal_api/public/syn...
sync/internal_api/public/sync_manager_factory.h:21: NORMAL,
Comment what these mean

https://codereview.chromium.org/265823009/diff/1/sync/internal_api/sync_manag...
File sync/internal_api/sync_manager_factory.cc (right):

https://codereview.chromium.org/265823009/diff/1/sync/internal_api/sync_manag...
sync/internal_api/sync_manager_factory.cc:26: return scoped_ptr<SyncManager>(new
SyncBackupManager);
nit: prefer explicitly noting that this is being default constructed by
including parens

[haitaol1, 2014-05-13 18:10:59]

https://codereview.chromium.org/265823009/diff/1/sync/internal_api/public/syn...
File sync/internal_api/public/sync_manager_factory.h (right):

https://codereview.chromium.org/265823009/diff/1/sync/internal_api/public/syn...
sync/internal_api/public/sync_manager_factory.h:21: NORMAL,
On 2014/05/13 17:49:15, Nicolas Zea wrote:
> Comment what these mean

Done.

https://codereview.chromium.org/265823009/diff/1/sync/internal_api/sync_manag...
File sync/internal_api/sync_manager_factory.cc (right):

https://codereview.chromium.org/265823009/diff/1/sync/internal_api/sync_manag...
sync/internal_api/sync_manager_factory.cc:26: return scoped_ptr<SyncManager>(new
SyncBackupManager);
On 2014/05/13 17:49:15, Nicolas Zea wrote:
> nit: prefer explicitly noting that this is being default constructed by
> including parens

Done.

[haitaol1, 2014-05-13 18:13:17]

The CQ bit was checked by haitaol@chromium.org

[commit-bot: I haz the power, 2014-05-13 18:13:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haitaol@chromium.org/265823009/20001

[commit-bot: I haz the power, 2014-05-13 22:37:25]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[commit-bot: I haz the power, 2014-05-13 23:03:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-13 23:03:16]

Try jobs failed on following builders:
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[haitaol1, 2014-05-13 23:22:31]

The CQ bit was checked by haitaol@chromium.org

[commit-bot: I haz the power, 2014-05-13 23:25:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haitaol@chromium.org/265823009/40001

[commit-bot: I haz the power, 2014-05-14 03:29:35]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-14 04:01:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-14 04:01:20]

Try jobs failed on following builders:
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)

[haitaol1, 2014-05-14 16:37:19]

The CQ bit was checked by haitaol@chromium.org

[commit-bot: I haz the power, 2014-05-14 16:37:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haitaol@chromium.org/265823009/60001

[commit-bot: I haz the power, 2014-05-14 19:12:43]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-05-14 19:28:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-14 19:28:14]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[haitaol1, 2014-05-14 22:44:21]

The CQ bit was checked by haitaol@chromium.org

[commit-bot: I haz the power, 2014-05-14 22:45:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haitaol@chromium.org/265823009/70001

[commit-bot: I haz the power, 2014-05-15 01:59:04]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)

[commit-bot: I haz the power, 2014-05-15 03:49:33]

Change committed as 270576