Issue 2658213003: Revert "Revert of Destroy incognito profile from close all incognito notification. (patchset #1 id:…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2658213003: Revert "Revert of Destroy incognito profile from close all incognito notification. (patchset #1 id:… (Closed)

Created:
3 years, 10 months ago by Ted C

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert "Revert of Destroy incognito profile from close all incognito notification. (patchset #1 id:1 of https://codereview.chromium.org/2653753008/ )" This reverts commit 61ef8268f9904aecb561105246c92d753ca53dda. BUG=673489

Patch Set 1 #

Patch Set 2 : Fix compilation from signature change on branch #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -5 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java	View		5 chunks	+62 lines, -1 line	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java	View	1	2 chunks	+16 lines, -4 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/BrowserStartupController.java	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Ted C

3 years, 10 months ago (2017-01-31 22:32:23 UTC) #1

Description was changed from

==========
Revert "Revert of Destroy incognito profile from close all incognito
notification. (patchset #1 id:1 of https://codereview.chromium.org/2653753008/
)"

This reverts commit 61ef8268f9904aecb561105246c92d753ca53dda.

BUG=673489
==========

to

==========
Revert "Revert of Destroy incognito profile from close all incognito
notification. (patchset #1 id:1 of https://codereview.chromium.org/2653753008/
)"

This reverts commit 61ef8268f9904aecb561105246c92d753ca53dda.

BUG=673489
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages