Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4463)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java

Issue 2658163003: [Android NTP] Cache number of items under child nodes (Closed)
Patch Set: review Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java
index 2b9d1f322f1f785e1f0f4a2e1234d0692bc20f35..93df5b6de4ca8e16a767258f88a450cd9a95ff7e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java
@@ -57,7 +57,7 @@ public class InnerNode extends ChildNode implements NodeParent {
}
@Override
- public int getItemCount() {
+ protected int getItemCountForDebugging() {
int numItems = 0;
for (TreeNode child : mChildren) {
numItems += child.getItemCount();
@@ -137,12 +137,13 @@ public class InnerNode extends ChildNode implements NodeParent {
*/
protected void addChildren(TreeNode... children) {
int initialCount = getItemCount();
+ int addedCount = 0;
for (TreeNode child : children) {
mChildren.add(child);
child.setParent(this);
+ addedCount += child.getItemCount();
}
- int addedCount = getItemCount() - initialCount;
if (addedCount > 0) notifyItemRangeInserted(initialCount, addedCount);
}

Powered by Google App Engine
This is Rietveld 408576698