Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: components/metrics/file_metrics_provider.h

Issue 2658163002: Merge histograms from providers into StatisticsRecorder for display. (Closed)
Patch Set: rebased Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/subprocess_metrics_provider.cc ('k') | components/metrics/file_metrics_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/file_metrics_provider.h
diff --git a/components/metrics/file_metrics_provider.h b/components/metrics/file_metrics_provider.h
index ba2e9f9571a0a9bc0734a9a676804d7015588bd1..080a8211dd2c0de10bc5c6d06ae6b94a6a462513 100644
--- a/components/metrics/file_metrics_provider.h
+++ b/components/metrics/file_metrics_provider.h
@@ -13,6 +13,7 @@
#include "base/files/file_path.h"
#include "base/gtest_prod_util.h"
#include "base/memory/weak_ptr.h"
+#include "base/metrics/statistics_recorder.h"
#include "base/threading/thread_checker.h"
#include "base/time/time.h"
#include "components/metrics/metrics_provider.h"
@@ -30,7 +31,8 @@ namespace metrics {
// Any number of files can be registered and will be polled once per upload
// cycle (at startup and periodically thereafter -- about every 30 minutes
// for desktop) for data to send.
-class FileMetricsProvider : public MetricsProvider {
+class FileMetricsProvider : public MetricsProvider,
+ public base::StatisticsRecorder::HistogramProvider {
public:
enum SourceType {
// "Atomic" files are a collection of histograms that are written
@@ -172,10 +174,12 @@ class FileMetricsProvider : public MetricsProvider {
// metrics::MetricsDataProvider:
void OnDidCreateMetricsLog() override;
bool HasInitialStabilityMetrics() override;
- void MergeHistogramDeltas() override;
void RecordInitialHistogramSnapshots(
base::HistogramSnapshotManager* snapshot_manager) override;
+ // base::StatisticsRecorder::HistogramProvider:
+ void MergeHistogramDeltas() override;
+
// A task-runner capable of performing I/O.
scoped_refptr<base::TaskRunner> task_runner_;
« no previous file with comments | « chrome/browser/metrics/subprocess_metrics_provider.cc ('k') | components/metrics/file_metrics_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698