Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: content/browser/histogram_internals_request_job.h

Issue 2658163002: Merge histograms from providers into StatisticsRecorder for display. (Closed)
Patch Set: some cleanup; added test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/histogram_internals_request_job.h
diff --git a/content/browser/histogram_internals_request_job.h b/content/browser/histogram_internals_request_job.h
index 63ce622e405a9a80bd4a61523d2ccd64d19aecde..130122a8529c1652b671b913fc85ccc5c3fe07f7 100644
--- a/content/browser/histogram_internals_request_job.h
+++ b/content/browser/histogram_internals_request_job.h
@@ -8,6 +8,7 @@
#include <string>
#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
#include "net/url_request/url_request_simple_job.h"
namespace content {
@@ -17,17 +18,24 @@ class HistogramInternalsRequestJob : public net::URLRequestSimpleJob {
HistogramInternalsRequestJob(net::URLRequest* request,
net::NetworkDelegate* network_delegate);
+ // URLRequestSimpleJob:
Alexei Svitkine (slow) 2017/01/27 16:22:03 Nit: net::
bcwhite 2017/01/27 18:05:31 Done.
+ void Start() override;
int GetData(std::string* mime_type,
std::string* charset,
std::string* data,
const net::CompletionCallback& callback) const override;
private:
- ~HistogramInternalsRequestJob() override {}
+ ~HistogramInternalsRequestJob() override;
+
+ // Starts the real URL request.
+ void StartUrlRequest();
// The string to select histograms which have |path_| as a substring.
std::string path_;
+ base::WeakPtrFactory<HistogramInternalsRequestJob> weak_factory_;
+
DISALLOW_IMPLICIT_CONSTRUCTORS(HistogramInternalsRequestJob);
};

Powered by Google App Engine
This is Rietveld 408576698