Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Unified Diff: tracing/tracing/metrics/tracing_metric.html

Issue 2658143002: Create a trace import duration metric (Closed)
Patch Set: Fixed tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tracing/tracing/metrics/tracing_metric_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/metrics/tracing_metric.html
diff --git a/tracing/tracing/metrics/tracing_metric.html b/tracing/tracing/metrics/tracing_metric.html
index fdc054f026580b2c9086cb09006724eb251d40ab..898fe806e4cfa0ee9bb569b9ef5ed9df0d963960 100644
--- a/tracing/tracing/metrics/tracing_metric.html
+++ b/tracing/tracing/metrics/tracing_metric.html
@@ -92,11 +92,16 @@ tr.exportTo('tr.metrics', function() {
histograms.addHistogram(traceBytesPerDumpValue);
}
+ // TODO(charliea): The metrics in this file should be renamed to have names
+ // more consistent with those in the rest of the codebase
+ // (e.g. 'trace_size_growth_per_second', not 'Max event size in bytes per
+ // second').
+ // https://github.com/catapult-project/catapult/issues/3233
function tracingMetric(histograms, model) {
- if (!model.stats.hasEventSizesinBytes) {
- throw new Error('Model stats does not have event size information. ' +
- 'Please enable ImportOptions.trackDetailedModelStats.');
- }
+ addTimeDurationHistogram(
+ 'trace_import_duration', model.stats.traceImportDurationMs, histograms);
+
+ if (!model.stats.hasEventSizesinBytes) return;
var eventStats = model.stats.allTraceEventStatsInTimeIntervals;
eventStats.sort(function(a, b) {
« no previous file with comments | « no previous file | tracing/tracing/metrics/tracing_metric_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698