Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 265813008: ozone: Fix chromeos=1 use_ozone=1 chrome build (Closed)

Created:
6 years, 7 months ago by spang
Modified:
6 years, 7 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

ozone: Fix chromeos=1 use_ozone=1 chrome build BUG=354034 TEST=build & unit_tests R=derat@chromium.org TBR=derat Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267934

Patch Set 1 #

Total comments: 1

Patch Set 2 : sort gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
spang
6 years, 7 months ago (2014-05-02 16:57:14 UTC) #1
spang
The CQ bit was checked by spang@chromium.org
6 years, 7 months ago (2014-05-02 16:58:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/265813008/1
6 years, 7 months ago (2014-05-02 16:59:09 UTC) #3
Daniel Erat
lgtm https://codereview.chromium.org/265813008/diff/1/chrome/chrome_browser_chromeos.gypi File chrome/chrome_browser_chromeos.gypi (right): https://codereview.chromium.org/265813008/diff/1/chrome/chrome_browser_chromeos.gypi#newcode1083 chrome/chrome_browser_chromeos.gypi:1083: 'browser/chromeos/events/system_key_event_listener.cc', nit: keep this list alphabetized
6 years, 7 months ago (2014-05-02 16:59:38 UTC) #4
spang
The CQ bit was unchecked by spang@chromium.org
6 years, 7 months ago (2014-05-02 17:00:52 UTC) #5
spang
The CQ bit was checked by spang@chromium.org
6 years, 7 months ago (2014-05-02 17:19:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/265813008/20001
6 years, 7 months ago (2014-05-02 17:19:48 UTC) #7
spang
Committed patchset #2 manually as r267934 (presubmit successful).
6 years, 7 months ago (2014-05-02 21:55:31 UTC) #8
Daniel Erat
6 years, 7 months ago (2014-05-06 16:09:07 UTC) #9
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698