Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 265813007: Mark drawbitmaprect's large bitmaps as immutable. (Closed)

Created:
6 years, 7 months ago by mtklein_C
Modified:
6 years, 7 months ago
Reviewers:
mtklein, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Mark drawbitmaprect's large bitmaps as immutable. This reduces the peak memory usage of out/Debug/dm --skr --match drawbitmaprect from ~1.6G to ~200M. I'm not sure how the numbers got so huge to begin with from a 2K x 2K 8888 bitmap (16MB). BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14529

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M gm/drawbitmaprect.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 7 months ago (2014-05-02 14:03:24 UTC) #1
reed1
lgtm https://codereview.chromium.org/265813007/diff/1/gm/drawbitmaprect.cpp File gm/drawbitmaprect.cpp (right): https://codereview.chromium.org/265813007/diff/1/gm/drawbitmaprect.cpp#newcode71 gm/drawbitmaprect.cpp:71: bm->setImmutable(); // mark as immutable to be nicer ...
6 years, 7 months ago (2014-05-02 14:10:59 UTC) #2
mtklein
lgtm https://codereview.chromium.org/265813007/diff/1/gm/drawbitmaprect.cpp File gm/drawbitmaprect.cpp (right): https://codereview.chromium.org/265813007/diff/1/gm/drawbitmaprect.cpp#newcode71 gm/drawbitmaprect.cpp:71: bm->setImmutable(); On 2014/05/02 14:11:00, reed1 wrote: > // ...
6 years, 7 months ago (2014-05-02 14:14:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/265813007/20001
6 years, 7 months ago (2014-05-02 14:14:23 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 14:22:41 UTC) #5
Message was sent while issue was closed.
Change committed as 14529

Powered by Google App Engine
This is Rietveld 408576698