Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Issue 2658123004: Resynthesize invalid types as 'dynamic'. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Resynthesize invalid types as 'dynamic'. There are 7 instances of this UnimplementedError internally. R=paulberry@google.com BUG= https://github.com/dart-lang/sdk/issues/27763 Committed: https://github.com/dart-lang/sdk/commit/0db78056dbbc0d1be5e7d94e225353fb1ca13a23

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-01-28 04:12:16 UTC) #1
Paul Berry
lgtm
3 years, 10 months ago (2017-01-28 14:08:46 UTC) #2
scheglov
3 years, 10 months ago (2017-01-28 18:11:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0db78056dbbc0d1be5e7d94e225353fb1ca13a23 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698