Fix missing borders on Autofill popups on Windows High DPI

Fix missing borders on Autofill popups on Windows High DPI

When the Widnows 10 display setting are for 125% or 150% zoom,
the borders on autofill entries are missing on some sides. This is
due to a mismatch int he rounding methods used to convert from floating
point rectangles to integers. This patch switches the popup layout code
to use Nearest rect rounding rather than Enclosing rect, to more
closely match the behavior of Display::SetScaleAndBounds.

R=mattp@chromium.org
BUG=685867

[Stephen Chennney, 2017-01-27 21:25:17]

The CQ bit was checked by schenney@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 21:26:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Stephen Chennney, 2017-01-27 21:27:51]

PTAL. Running it through a CQ dry run.

I'm fine if we decide not to land this and put more work into a better fix.
There should also be some testing of some form. However, my work day is done and
I'll be away from a Windows 10 machine next week, so I figure it's worth putting
this up for others to build on (or just land if that's OK with everyone).

[Stephen Chennney, 2017-01-27 21:30:03]

On 2017/01/27 21:27:51, Stephen Chennney wrote:
> PTAL. Running it through a CQ dry run.
> 
> I'm fine if we decide not to land this and put more work into a better fix.
> There should also be some testing of some form. However, my work day is done
and
> I'll be away from a Windows 10 machine next week, so I figure it's worth
putting
> this up for others to build on (or just land if that's OK with everyone).

This does not fix the 175% case, as expected because the layer rounds down but
my change will still round up in that case.

[commit-bot: I haz the power, 2017-01-27 22:39:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 22:39:23]

Dry run: This issue passed the CQ dry run.

[Stephen Chennney, 2017-03-02 15:05:01]

Description was changed from

==========
Fix missing borders on Autofill popups on Windows High DPI

When the Widnows 10 display setting are for 125% or 150% zoom,
the borders on autofill entries are missing on some sides. This is
due to a mismatch int he rounding methods used to convert from floating
point rectangles to integers. This patch switches the popup layout code
to use Nearest rect rounding rather than Enclosing rect, to more
closely match the behavior of Display::SetScaleAndBounds.

R=mattp@chromium.org
BUG=685867
==========

to

==========
Fix missing borders on Autofill popups on Windows High DPI

When the Widnows 10 display setting are for 125% or 150% zoom,
the borders on autofill entries are missing on some sides. This is
due to a mismatch int he rounding methods used to convert from floating
point rectangles to integers. This patch switches the popup layout code
to use Nearest rect rounding rather than Enclosing rect, to more
closely match the behavior of Display::SetScaleAndBounds.

R=mattp@chromium.org
BUG=685867
==========