Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

Issue 2658103002: [Payments] Add CanMakePayment metrics. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
index 4ba0c34499b6b9b9dc51848575d03484185cb6c3..8d37d6afc5148b912f0228290f0a9da5199c7c23 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
@@ -479,6 +479,7 @@ public class PaymentRequestImpl
mUI.show();
recordSuccessFunnelHistograms("Shown");
+ mJourneyLogger.setShowCalled();
}
private static Map<String, PaymentMethodData> getValidatedMethodData(
@@ -1148,12 +1149,16 @@ public class PaymentRequestImpl
}
query.addObserver(this);
- if (isFinishedQueryingPaymentApps()) query.setResponse(mCanMakePayment);
+ if (isFinishedQueryingPaymentApps()) {
+ query.setResponse(mCanMakePayment);
+ mJourneyLogger.setCanMakePaymentValue(mCanMakePayment);
+ }
}
private void respondCanMakePaymentQuery(boolean response) {
mClient.onCanMakePayment(response ? CanMakePaymentQueryResult.CAN_MAKE_PAYMENT
: CanMakePaymentQueryResult.CANNOT_MAKE_PAYMENT);
+ mJourneyLogger.setCanMakePaymentValue(mCanMakePayment);
if (sObserverForTest != null) {
sObserverForTest.onPaymentRequestServiceCanMakePaymentQueryResponded();
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698