Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2658093007: Update rasta direct expectations. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebased on 5f1092d494bc8cae2b10917fc41c46764e867923. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -207 lines) Patch
M pkg/front_end/test/fasta/rasta/abstract_constructor.dart.direct.expect View 1 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/bad_constructor_redirection.dart.direct.expect View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/bad_continue.dart.direct.expect View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/rasta/bad_explicit_super_constructor.dart.direct.expect View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/bad_setter_initializer.dart.direct.expect View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/breaking_bad.dart.direct.expect View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/rasta/cascades.dart.direct.expect View 1 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/class_member.dart.direct.expect View 1 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/deferred_load.dart.direct.expect View 1 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/duplicated_mixin.dart.direct.expect View 1 1 chunk +18 lines, -14 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/enum.dart.direct.expect View 1 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/external_factory_redirection.dart.direct.expect View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/rasta/generic_factory.dart.direct.expect View 1 4 chunks +14 lines, -11 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000001.dart.direct.expect View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000002.dart.direct.expect View 1 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000004.dart.direct.expect View 1 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000007.dart.direct.expect View 1 1 chunk +14 lines, -10 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000008.dart.direct.expect View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000012.dart.direct.expect View 1 1 chunk +8 lines, -6 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000025.dart.direct.expect View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000026.dart.direct.expect View 1 1 chunk +11 lines, -10 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000031.dart.direct.expect View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000034.dart.direct.expect View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000035.dart.direct.expect View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000043.dart.direct.expect View 1 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000053.dart.direct.expect View 1 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000067.dart.direct.expect View 1 1 chunk +10 lines, -9 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000068.dart.direct.expect View 1 1 chunk +19 lines, -15 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000069.dart.direct.expect View 1 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000070.dart.direct.expect View 1 1 chunk +16 lines, -14 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000080.dart.direct.expect View 1 1 chunk +15 lines, -12 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000081.dart.direct.expect View 1 1 chunk +10 lines, -8 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/malformed_function.dart.direct.expect View 1 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/mixin_library.dart.direct.expect View 1 1 chunk +8 lines, -7 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/super_initializer.dart.direct.expect View 1 1 chunk +9 lines, -9 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/super_operator.dart.direct.expect View 1 2 chunks +11 lines, -8 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/supports_reflection.dart.direct.expect View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/rasta/switch_execution_case_t02.dart.direct.expect View 1 1 chunk +3 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/rasta/switch_fall_through.dart.direct.expect View 1 3 chunks +22 lines, -14 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/this_invoke.dart.direct.expect View 1 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/type_literals.dart.direct.expect View 1 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/unresolved.dart.direct.expect View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/rasta/unresolved_constructor.dart.direct.expect View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
Expect to see this: * Constructor return type changed to void (this is what dartk ...
3 years, 10 months ago (2017-01-27 23:12:22 UTC) #2
karlklose
LGTM
3 years, 10 months ago (2017-01-31 11:30:05 UTC) #3
ahe
3 years, 10 months ago (2017-02-01 12:32:49 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
683fe6ab7c1925cfb63f7b36a7ff6088e4ff937e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698