Remove ScopedVector in components/spellcheck

components/spellcheck/browser/feedback_sender.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The |FeedbackSender| object stores the user feedback to spellcheck
 // suggestions in a |Feedback| object.
 //
 // When spelling service returns spellcheck results, these results first arrive
 // in |FeedbackSender| to assign hash identifiers for each
 // misspelling-suggestion pair. If the spelling service identifies the same
@@ skipping 19 matching lines @@
 #include "components/spellcheck/browser/feedback_sender.h"
 
 #include <algorithm>
 #include <iterator>
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/hash.h"
 #include "base/json/json_writer.h"
 #include "base/location.h"
+#include "base/memory/ptr_util.h"
 #include "base/metrics/field_trial.h"
 #include "base/single_thread_task_runner.h"
 #include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "base/values.h"
 #include "components/data_use_measurement/core/data_use_user_data.h"
 #include "components/spellcheck/browser/word_trimmer.h"
 #include "components/spellcheck/common/spellcheck_common.h"
@@ skipping 319 matching lines @@
 
   FlushFeedback();
   timer_.Stop();
 }
 
 void FeedbackSender::RandBytes(void* p, size_t len) {
   crypto::RandBytes(p, len);
 }
 
 void FeedbackSender::OnURLFetchComplete(const net::URLFetcher* source) {
-  for (ScopedVector<net::URLFetcher>::iterator sender_it = senders_.begin();
-       sender_it != senders_.end();
+  for (auto sender_it = senders_.begin(); sender_it != senders_.end();
        ++sender_it) {
-    if (*sender_it == source) {
+    if ((*sender_it).get() == source) {
       senders_.erase(sender_it);
       return;
     }
   }
   delete source;
 }
 
 void FeedbackSender::RequestDocumentMarkers() {
   // Request document markers from all the renderers that are still alive.
   std::set<int> alive_renderers;
@@ skipping 49 matching lines @@
   // The tests use this identifier to mock the URL fetcher.
   static const int kUrlFetcherId = 0;
   net::URLFetcher* sender =
       net::URLFetcher::Create(kUrlFetcherId, feedback_service_url_,
                               net::URLFetcher::POST, this).release();
   data_use_measurement::DataUseUserData::AttachToFetcher(
       sender, data_use_measurement::DataUseUserData::SPELL_CHECKER);
   sender->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |
                        net::LOAD_DO_NOT_SAVE_COOKIES);
   sender->SetUploadData("application/json", feedback);
-  senders_.push_back(sender);
+  senders_.push_back(base::WrapUnique<net::URLFetcher>(sender));

[groby-ooo-7-16, 2017/01/26 17:40:47]

This should probably be a unique_ptr from creation, and std::move at this point.

[ke.he, 2017/01/27 03:15:40]

Done.

 
   // Request context is nullptr in testing.
   if (request_context_.get()) {
     sender->SetRequestContext(request_context_.get());
     sender->Start();
   }
 }
 
 }  // namespace spellcheck