Issue 2658003: [GTTF] Use FRIEND_TEST_ALL_PREFIXES in chrome/browser/sync

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2658003: [GTTF] Use FRIEND_TEST_ALL_PREFIXES in chrome/browser/sync (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 12 months ago by Paweł Hajdan Jr.

Modified:
4 years ago

Reviewers:
Bernhard Bauer, ncarter, timsteele

CC:
chromium-reviews

Visibility:
Public.

[GTTF] Use FRIEND_TEST_ALL_PREFIXES in chrome/browser/sync TEST=none BUG=44549 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49381

Created: 4 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -57 lines)			Patch
M	chrome/browser/sync/engine/auth_watcher.h	View	3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/engine/conflict_resolver.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/engine/syncapi.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer.h	View	3 chunks	+18 lines, -16 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer_proto_util.h	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer_thread.h	View	3 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.h	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/sync_setup_flow.h	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/sync/syncable/directory_backing_store.h	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/sync/syncable/syncable.h	View	3 chunks	+5 lines, -3 lines	0 comments	Download

Trybot results: mac win linux

Total messages: 3 (0 generated)

Paweł Hajdan Jr.

See the bug for some context. This should make build breakages when changing test prefixes ...

4 years, 12 months ago (2010-06-04 11:21:32 UTC) #1

LGTM.