Source/core/dom/Element.cpp - Issue 265793017: Oilpan: move node/element rare data objects to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.cpp

Issue 265793017: Oilpan: move node/element rare data objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Adjust MutationObserverRegistration::create() signature slightly Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Element.cpp

diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp

index 08b8d3ed6a9655b519f22145c83b2d22850a822c..a93fdc4b3f67b54af5227a44a99687ff1c6ec3d9 100644

--- a/Source/core/dom/Element.cpp

+++ b/Source/core/dom/Element.cpp

@@ -167,11 +167,10 @@ Element::~Element()

{

ASSERT(needsAttach());

+#if !ENABLE(OILPAN)

if (hasRareData())

elementRareData()->clearShadow();

haraken 2014/05/05 16:54:52 Sorry for a repeated question: In oilpan builds, n

- if (hasActiveAnimations())

- activeAnimations()->dispose();

+#endif

if (isCustomElement())

CustomElement::wasDestroyed(this);

@@ -1430,7 +1429,7 @@ void Element::detach(const AttachContext& context)

if (ActiveAnimations* activeAnimations = data->activeAnimations()) {

if (context.performingReattach) {

- // FIXME: We call detach from withing style recalc, so compositingState is not up to date.

+ // FIXME: We call detach from within style recalc, so compositingState is not up to date.

// https://code.google.com/p/chromium/issues/detail?id=339847

DisableCompositingQueryAsserts disabler;

« Source/core/animation/ActiveAnimations.h ('K') | « Source/core/dom/Document.cpp ('k') | Source/core/dom/ElementRareData.h » ('j') | Source/core/dom/MutationObserverRegistration.h » ('J')