Source/core/dom/shadow/ShadowRoot.cpp - Issue 265793017: Oilpan: move node/element rare data objects to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/shadow/ShadowRoot.cpp

Issue 265793017: Oilpan: move node/element rare data objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased + assert for Nodes having no renderer on destruction. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/shadow/ShadowRoot.cpp

diff --git a/Source/core/dom/shadow/ShadowRoot.cpp b/Source/core/dom/shadow/ShadowRoot.cpp

index 896f38f731ff3cf87956e1545280f2657ba855fa..3b26999a7a3c3c46d7ec4c23b5a4ec0bbc25f6b4 100644

--- a/Source/core/dom/shadow/ShadowRoot.cpp

+++ b/Source/core/dom/shadow/ShadowRoot.cpp

@@ -90,8 +90,10 @@ ShadowRoot::~ShadowRoot()

// We must call clearRareData() here since a ShadowRoot class inherits TreeScope

// as well as Node. See a comment on TreeScope.h for the reason.

+#if !ENABLE(OILPAN)

if (hasRareData())

clearRareData();

+#endif

}

void ShadowRoot::dispose()

« Source/core/dom/Node.cpp ('K') | « Source/core/dom/shadow/ElementShadow.cpp ('k') | Source/core/html/forms/TextFieldInputType.cpp » ('j') | no next file with comments »