Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: Source/core/animation/ActiveAnimations.h

Issue 265793017: Oilpan: move node/element rare data objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased + have MutationObserver keep a weak ref to registrations Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/animation/ActiveAnimations.cpp » ('j') | Source/core/dom/ElementRareData.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/ActiveAnimations.h
diff --git a/Source/core/animation/ActiveAnimations.h b/Source/core/animation/ActiveAnimations.h
index 1a4c0a0bb119a4b2f93e11c8cf203ba90549652f..966f73c12ead068bfb845eff5c9a09464cfb6f54 100644
--- a/Source/core/animation/ActiveAnimations.h
+++ b/Source/core/animation/ActiveAnimations.h
@@ -53,7 +53,6 @@ public:
}
~ActiveAnimations();
- void dispose();
// Animations that are currently active for this element, their effects will be applied
// during a style recalc. CSS Transitions are included in this stack.
@@ -94,6 +93,16 @@ private:
// won't be needed once Element and Animation are moved to Oilpan.
Vector<Animation*> m_animations;
+#if ENABLE(OILPAN)
+ // Keep a back reference to the target Element, so that this object
+ // will be finalized during the same GC sweep as the target (as the
+ // Element keeps a reference in the other direction via its
+ // rare data.) This is done so that we can accurately notify the
+ // the Element as destroyed to the above vector of Animations in
+ // the ActiveAnimations finalizer.
+ Member<Element> m_target;
+#endif
+
// CSSAnimations checks if a style change is due to animation.
friend class CSSAnimations;
};
« no previous file with comments | « no previous file | Source/core/animation/ActiveAnimations.cpp » ('j') | Source/core/dom/ElementRareData.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698