Source/core/dom/MutationObserverRegistration.h - Issue 265793017: Oilpan: move node/element rare data objects to the heap.

Side by Side Diff: Source/core/dom/MutationObserverRegistration.h

Issue 265793017: Oilpan: move node/element rare data objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased + EventHandler.cpp oilpan compile fix Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011 Google Inc. All rights reserved.	2 * Copyright (C) 2011 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 51 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
62 void addRegistrationNodesToSet(HashSet<Node*>&) const;	62 void addRegistrationNodesToSet(HashSet<Node*>&) const;

63	63

64 void trace(Visitor*);	64 void trace(Visitor*);

65	65

66 void dispose();	66 void dispose();

67	67

68 private:	68 private:

69 MutationObserverRegistration(MutationObserver&, Node&, MutationObserverOptio ns, const HashSet<AtomicString>& attributeFilter);	69 MutationObserverRegistration(MutationObserver&, Node&, MutationObserverOptio ns, const HashSet<AtomicString>& attributeFilter);

70	70

71 RefPtrWillBeMember<MutationObserver> m_observer;	71 RefPtrWillBeMember<MutationObserver> m_observer;

72 Node& m_registrationNode;	72 RawPtrWillBeMember<Node> m_registrationNode;

	73 #if !ENABLE(OILPAN)

73 RefPtr<Node> m_registrationNodeKeepAlive;	74 RefPtr<Node> m_registrationNodeKeepAlive;
	haraken 2014/05/04 01:46:24 We won't be able to remove this until we make the We won't be able to remove this until we make the Node hierarchy traceable (by the next change from Mads). Currently a Member to a Node X keeps X alive but does not keep other Nodes in the same tree alive. sof 2014/05/04 06:33:26 Hmm, quite right. It might be an odd thing to test Show quoted text On 2014/05/04 01:46:24, haraken wrote: > > We won't be able to remove this until we make the Node hierarchy traceable (by > the next change from Mads). Currently a Member to a Node X keeps X alive but > does not keep other Nodes in the same tree alive. Hmm, quite right. It might be an odd thing to test for, but no problems directly relating to this seen. Leaving it in with a FIXME is an alternative without waiting on that larger change, I think.
	75 #endif

74 typedef HashSet<RefPtr<Node> > NodeHashSet;	76 typedef HashSet<RefPtr<Node> > NodeHashSet;

75 OwnPtr<NodeHashSet> m_transientRegistrationNodes;	77 OwnPtr<NodeHashSet> m_transientRegistrationNodes;

76	78

77 MutationObserverOptions m_options;	79 MutationObserverOptions m_options;

78 HashSet<AtomicString> m_attributeFilter;	80 HashSet<AtomicString> m_attributeFilter;

79 };	81 };

80	82

81 } // namespace WebCore	83 } // namespace WebCore

82	84

83 #endif // MutationObserverRegistration_h	85 #endif // MutationObserverRegistration_h

OLD	NEW

« Source/core/dom/Element.cpp ('K') | « Source/core/dom/MutationObserver.cpp ('k') | Source/core/dom/MutationObserverRegistration.cpp » ('j') | Source/core/dom/Node.cpp » ('J')