gm/rebaseline_server/compare_configs.py - Issue 265793013: make compare_rendered_pictures process render_pictures's new JSON output format

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/rebaseline_server/compare_configs.py

Issue 265793013: make compare_rendered_pictures process render_pictures's new JSON output format (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: add Eric's idea as comment Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gm/rebaseline_server/compare_configs.py

diff --git a/gm/rebaseline_server/compare_configs.py b/gm/rebaseline_server/compare_configs.py

index ba256cab603d157bf35498697222e4fea8ffe228..e84de9ae159d14b8e82318de39406b6eae8b2d25 100755

--- a/gm/rebaseline_server/compare_configs.py

+++ b/gm/rebaseline_server/compare_configs.py

@@ -88,7 +88,8 @@ class ConfigComparisons(results.BaseComparisons):

"""

logging.info('Reading actual-results JSON files from %s...' %

self._actuals_root)

- actual_builder_dicts = self._read_dicts_from_root(self._actuals_root)

+ actual_builder_dicts = self._read_builder_dicts_from_root(

+ self._actuals_root)

configA, configB = configs

logging.info('Comparing configs %s and %s...' % (configA, configB))

« no previous file with comments | « gm/gm_json.py ('k') | gm/rebaseline_server/compare_rendered_pictures.py » ('j') | no next file with comments »