gm/rebaseline_server/testdata/outputs/expected/compare_rendered_pictures_test.CompareRenderedPicturesTest.test_endToEnd/compare_rendered_pictures.json - Issue 265793013: make compare_rendered_pictures process render_pictures's new JSON output format

Unified Diff: gm/rebaseline_server/testdata/outputs/expected/compare_rendered_pictures_test.CompareRenderedPicturesTest.test_endToEnd/compare_rendered_pictures.json

Issue 265793013: make compare_rendered_pictures process render_pictures's new JSON output format (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: check input JSON type/revision, and misc cleanup Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gm/rebaseline_server/testdata/inputs/render_pictures_output/after_patch/builder1/output.json ('K') | « gm/rebaseline_server/testdata/inputs/render_pictures_output/before_patch/builder1/output.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gm/rebaseline_server/testdata/outputs/expected/compare_rendered_pictures_test.CompareRenderedPicturesTest.test_endToEnd/compare_rendered_pictures.json

diff --git a/gm/rebaseline_server/testdata/outputs/expected/compare_rendered_pictures_test.CompareRenderedPicturesTest.test_endToEnd/compare_rendered_pictures.json b/gm/rebaseline_server/testdata/outputs/expected/compare_rendered_pictures_test.CompareRenderedPicturesTest.test_endToEnd/compare_rendered_pictures.json

index c60c7873f90d1ac615effd55a75c94b2864331cc..26fa884d80f3225143c3bf2aa54cb4204b91bc8f 100644

--- a/gm/rebaseline_server/testdata/outputs/expected/compare_rendered_pictures_test.CompareRenderedPicturesTest.test_endToEnd/compare_rendered_pictures.json

+++ b/gm/rebaseline_server/testdata/outputs/expected/compare_rendered_pictures_test.CompareRenderedPicturesTest.test_endToEnd/compare_rendered_pictures.json

@@ -5,7 +5,7 @@

"isFilterable": true,

"isSortable": true,

"valuesAndCounts": {

- "builder1": 2

+ "TODO": 2

}

"config": {

@@ -13,7 +13,7 @@

"isFilterable": true,

"isSortable": true,

"valuesAndCounts": {

- "TODO": 2

+ "whole-image": 2

}

"resultType": {

@@ -31,13 +31,13 @@

"isFilterable": true,

"isSortable": true,

"valuesAndCounts": {

- "changed.png": 1,

- "unchanged.png": 1

+ "changed.skp": 1,

+ "unchanged.skp": 1

}

"header": {

- "dataHash": "3972200251153667246",

+ "dataHash": "87483773534327784",

"isEditable": false,

"isExported": true,

"schemaVersion": 2,

@@ -48,24 +48,24 @@

"imagePairs": [

{

"extraColumns": {

- "builder": "builder1",

- "config": "TODO",

+ "builder": "TODO",

+ "config": "whole-image",

"resultType": "failed",

- "test": "changed.png"

+ "test": "changed.skp"

- "imageAUrl": "bitmap-64bitMD5/changed_png/8891695120562235492.png",

- "imageBUrl": "bitmap-64bitMD5/changed_png/2520753504544298264.png",

+ "imageAUrl": "bitmap-64bitMD5_8891695120562235492.png",

+ "imageBUrl": "bitmap-64bitMD5_2520753504544298264.png",

"isDifferent": true

{

"extraColumns": {

- "builder": "builder1",

- "config": "TODO",

+ "builder": "TODO",

+ "config": "whole-image",

"resultType": "succeeded",

- "test": "unchanged.png"

+ "test": "unchanged.skp"

- "imageAUrl": "bitmap-64bitMD5/unchanged_png/11092453015575919668.png",

- "imageBUrl": "bitmap-64bitMD5/unchanged_png/11092453015575919668.png",

+ "imageAUrl": "bitmap-64bitMD5_11092453015575919668.png",

+ "imageBUrl": "bitmap-64bitMD5_11092453015575919668.png",

"isDifferent": false

}