Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Side by Side Diff: gm/rebaseline_server/compare_configs.py

Issue 265793013: make compare_rendered_pictures process render_pictures's new JSON output format (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: add Eric's idea as comment Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gm/gm_json.py ('k') | gm/rebaseline_server/compare_rendered_pictures.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 2
3 """ 3 """
4 Copyright 2014 Google Inc. 4 Copyright 2014 Google Inc.
5 5
6 Use of this source code is governed by a BSD-style license that can be 6 Use of this source code is governed by a BSD-style license that can be
7 found in the LICENSE file. 7 found in the LICENSE file.
8 8
9 Compare GM results for two configs, across all builders. 9 Compare GM results for two configs, across all builders.
10 """ 10 """
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 def _load_config_pairs(self, configs): 81 def _load_config_pairs(self, configs):
82 """Loads the results of all tests, across all builders (based on the 82 """Loads the results of all tests, across all builders (based on the
83 files within self._actuals_root), compares them across two configs, 83 files within self._actuals_root), compares them across two configs,
84 and stores the summary in self._results. 84 and stores the summary in self._results.
85 85
86 Args: 86 Args:
87 configs: tuple of strings; pair of configs to compare 87 configs: tuple of strings; pair of configs to compare
88 """ 88 """
89 logging.info('Reading actual-results JSON files from %s...' % 89 logging.info('Reading actual-results JSON files from %s...' %
90 self._actuals_root) 90 self._actuals_root)
91 actual_builder_dicts = self._read_dicts_from_root(self._actuals_root) 91 actual_builder_dicts = self._read_builder_dicts_from_root(
92 self._actuals_root)
92 configA, configB = configs 93 configA, configB = configs
93 logging.info('Comparing configs %s and %s...' % (configA, configB)) 94 logging.info('Comparing configs %s and %s...' % (configA, configB))
94 95
95 all_image_pairs = imagepairset.ImagePairSet( 96 all_image_pairs = imagepairset.ImagePairSet(
96 descriptions=configs, 97 descriptions=configs,
97 diff_base_url=self._diff_base_url) 98 diff_base_url=self._diff_base_url)
98 failing_image_pairs = imagepairset.ImagePairSet( 99 failing_image_pairs = imagepairset.ImagePairSet(
99 descriptions=configs, 100 descriptions=configs,
100 diff_base_url=self._diff_base_url) 101 diff_base_url=self._diff_base_url)
101 102
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 results_obj = ConfigComparisons(configs=args.config, 214 results_obj = ConfigComparisons(configs=args.config,
214 actuals_root=args.actuals, 215 actuals_root=args.actuals,
215 generated_images_root=args.workdir) 216 generated_images_root=args.workdir)
216 gm_json.WriteToFile( 217 gm_json.WriteToFile(
217 results_obj.get_packaged_results_of_type(results_type=args.results), 218 results_obj.get_packaged_results_of_type(results_type=args.results),
218 args.outfile) 219 args.outfile)
219 220
220 221
221 if __name__ == '__main__': 222 if __name__ == '__main__':
222 main() 223 main()
OLDNEW
« no previous file with comments | « gm/gm_json.py ('k') | gm/rebaseline_server/compare_rendered_pictures.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698