Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 265793002: BrowserMediaPlayerManager: Call OnKeyAdded() on the correct player. (Closed)

Created:
6 years, 7 months ago by xhwang
Modified:
6 years, 7 months ago
Reviewers:
qinmin
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, avayvod+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

BrowserMediaPlayerManager: Call OnKeyAdded() on the correct player. BUG=368917 TEST=Test player resumes playback after key added. R=qinmin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267946

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : comments addressed #

Patch Set 4 : rebase only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M content/browser/media/android/browser_media_player_manager.h View 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.cc View 1 2 3 4 chunks +23 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
xhwang
PTAL
6 years, 7 months ago (2014-05-01 01:20:26 UTC) #1
xhwang
kindly ping...
6 years, 7 months ago (2014-05-02 17:02:53 UTC) #2
qinmin
lgtm https://codereview.chromium.org/265793002/diff/20001/content/browser/media/android/browser_media_player_manager.cc File content/browser/media/android/browser_media_player_manager.cc (right): https://codereview.chromium.org/265793002/diff/20001/content/browser/media/android/browser_media_player_manager.cc#newcode797 content/browser/media/android/browser_media_player_manager.cc:797: drm_bridge_player_map_[cdm_id] = player_id; do we need a dcheck ...
6 years, 7 months ago (2014-05-02 18:48:57 UTC) #3
xhwang
comments addressed
6 years, 7 months ago (2014-05-02 18:54:55 UTC) #4
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 7 months ago (2014-05-02 18:56:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/265793002/40001
6 years, 7 months ago (2014-05-02 18:56:33 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 19:21:12 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 19:21:13 UTC) #8
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 7 months ago (2014-05-02 19:56:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/265793002/40001
6 years, 7 months ago (2014-05-02 19:56:56 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 20:27:03 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 20:27:03 UTC) #12
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 7 months ago (2014-05-02 20:37:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/265793002/40001
6 years, 7 months ago (2014-05-02 20:37:16 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 21:00:26 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 21:00:27 UTC) #16
xhwang
rebase only
6 years, 7 months ago (2014-05-02 22:37:48 UTC) #17
xhwang
6 years, 7 months ago (2014-05-02 22:38:32 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 manually as r267946 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698