Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4260)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java

Issue 2657923002: Add a Kill switch for WebVR cardboard support through finch. (Closed)
Patch Set: Formating Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
index 4325a3673764191cab87f314aab9ebc12c9d144c..5428229ec9ffcc248bceb0bf6179e1135f29a313 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
@@ -48,6 +48,23 @@ public abstract class ChromeFeatureList {
return sTestEnabledFeatures.contains(featureName);
}
+ /**
+ * Returns a field trial param as an int for the specified feature.
+ *
+ * Note: Features queried through this API must be added to the array
+ * |kFeaturesExposedToJava| in chrome/browser/android/chrome_feature_list.cc
+ *
+ * @param featureName The name of the feature to retrieve a param for.
+ * @param paramName The name of the param for which to get as an integer.
+ * @param defaultValue The integer value to use if the param is not available.
+ * @return The parameter value as an int. Default value if the feature does not exist or the
+ * specified parameter does not exist.
+ */
+ public static long getFieldTrialParamByFeatureAsInt(
+ String featureName, String paramName, int defaultValue) {
+ return nativeGetFieldTrialParamByFeatureAsInt(featureName, paramName, defaultValue);
+ }
+
// Alphabetical:
public static final String ANDROID_PAY_INTEGRATION_V1 = "AndroidPayIntegrationV1";
public static final String ANDROID_PAY_INTEGRATION_V2 = "AndroidPayIntegrationV2";
@@ -77,6 +94,9 @@ public abstract class ChromeFeatureList {
public static final String WEB_PAYMENTS = "WebPayments";
public static final String WEB_PAYMENTS_MODIFIERS = "WebPaymentsModifiers";
public static final String WEB_PAYMENTS_SINGLE_APP_UI_SKIP = "WebPaymentsSingleAppUiSkip";
+ public static final String WEBVR_CARDBOARD_SUPPORT = "WebVRCardboardSupport";
private static native boolean nativeIsEnabled(String featureName);
+ private static native int nativeGetFieldTrialParamByFeatureAsInt(
+ String featureName, String paramName, int defaultValue);
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698