Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: components/variations/android/variations_associated_data_android.cc

Issue 2657923002: Add a Kill switch for WebVR cardboard support through finch. (Closed)
Patch Set: Fix javadoc Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/variations/android/variations_associated_data_android.cc
diff --git a/components/variations/android/variations_associated_data_android.cc b/components/variations/android/variations_associated_data_android.cc
index 1dd8096978135ee2e98de025f274ec16809dce1c..eac4ee58dd486bbaeb856d1f25c8588b4945b59f 100644
--- a/components/variations/android/variations_associated_data_android.cc
+++ b/components/variations/android/variations_associated_data_android.cc
@@ -20,6 +20,25 @@ namespace variations {
namespace android {
+jint GetVariationParamByFeatureAsInt(
+ JNIEnv* env,
+ const JavaParamRef<jclass>& clazz,
+ const jlong jfeature,
+ const JavaParamRef<jstring>& jparam_name,
+ const jint jdefault_value) {
+
+ base::Feature * feature = reinterpret_cast<base::Feature*>(jfeature);
+ if (feature == nullptr) {
+ return jdefault_value;
+ }
+
+ std::string param_name(ConvertJavaStringToUTF8(env, jparam_name));
+ int default_value = static_cast<int>(jdefault_value);
+
rkaplow 2017/01/31 18:17:44 this recently got deprecated to the base:: version
amp 2017/01/31 18:41:43 Acknowledged. I'll update to the non-deprecated c
+ return variations::GetVariationParamByFeatureAsInt(
+ *feature, param_name, default_value);
+}
+
ScopedJavaLocalRef<jstring> GetVariationParamValue(
JNIEnv* env,
const JavaParamRef<jclass>& clazz,

Powered by Google App Engine
This is Rietveld 408576698