Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2634)

Unified Diff: appengine/findit/crash/predator.py

Issue 2657913002: [Predator] Add ``Project`` class and ``ClassifySuspect`` method to project and component classifier (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/predator.py
diff --git a/appengine/findit/crash/predator.py b/appengine/findit/crash/predator.py
index 9040ff302d842d9a07d8cfb28ae873b569e037ad..1a0e3bfacfde77446ee5b3cd24e26997d44ab6d6 100644
--- a/appengine/findit/crash/predator.py
+++ b/appengine/findit/crash/predator.py
@@ -18,11 +18,15 @@ class Predator(object): # pragma: no cover
suspected_cls = self.cl_classifier(report)
assert suspected_cls is not None
- suspected_project = self.project_classifier.Classify(
- suspected_cls, report.stacktrace.crash_stack)
+ suspected_project = (
+ self.project_classifier.ClassifySuspects(suspected_cls) or
+ self.project_classifier.ClassifyCallStack(
+ report.stacktrace.crash_stack))
- suspected_components = self.component_classifier.Classify(
- suspected_cls, report.stacktrace.crash_stack)
+ suspected_components = (
+ self.component_classifier.ClassifySuspects(suspected_cls) or
+ self.component_classifier.ClassifyCallStack(
+ report.stacktrace.crash_stack))
return Culprit(
project = suspected_project,

Powered by Google App Engine
This is Rietveld 408576698