appengine/findit/crash/test/findit_for_chromecrash_test.py - Issue 2657913002: [Predator] Add ``Project`` class and ``ClassifySuspect`` method to project and component classifier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/crash/test/findit_for_chromecrash_test.py

Issue 2657913002: [Predator] Add ``Project`` class and ``ClassifySuspect`` method to project and component classifier (Closed)

Patch Set: Fix nits. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/findit/crash/test/findit_for_chromecrash_test.py

diff --git a/appengine/findit/crash/test/findit_for_chromecrash_test.py b/appengine/findit/crash/test/findit_for_chromecrash_test.py

index dbe3a6a45e8aa98682e1b49582786a58792102c5..5c376a0b00aa01a8521ffbe19c105c90a79f86a0 100644

--- a/appengine/findit/crash/test/findit_for_chromecrash_test.py

+++ b/appengine/findit/crash/test/findit_for_chromecrash_test.py

@@ -205,8 +205,10 @@ class FinditForFracasTest(PredatorTestCase):

lambda _self, report:

[dummy_suspect] if report.regression_range else [])

- self.mock(ComponentClassifier, 'Classify', lambda *_: [])

- self.mock(ProjectClassifier, 'Classify', lambda *_: '')

+ self.mock(ComponentClassifier, 'ClassifySuspects', lambda *_: [])

+ self.mock(ComponentClassifier, 'ClassifyCallStack', lambda *_: [])

+ self.mock(ProjectClassifier, 'ClassifySuspects', lambda *_: '')

+ self.mock(ProjectClassifier, 'ClassifyCallStack', lambda *_: '')

# TODO(wrengr): for both these tests, we should compare Culprit

# objects directly rather than calling ToDicts and comparing the