Issue 2657903006: Implement using AnalysisDriver in analyzer_cli. Disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2657903006: Implement using AnalysisDriver in analyzer_cli. Disabled. (Closed)

Created:
3 years, 11 months ago by scheglov

Modified:
3 years, 11 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Implement using AnalysisDriver in analyzer_cli. Disabled. It's not ready to be enabled yet. There are 11 failing tests in tests/language, and 174 in tests/co19. It also works about 5 times slower. But I'd like to land it to make parallel changes to AnalysisDriver and analyzer_cli to make it pass more tests and be faster. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/a3cc5fe7f79fc3a2a896f95ab308e0f0319d3851

Patch Set 1 #

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -20 lines)			Patch
M	pkg/analyzer/lib/src/dart/analysis/driver.dart	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	pkg/analyzer_cli/lib/src/analyzer_impl.dart	View	6 chunks	+23 lines, -6 lines	0 comments	Download
M	pkg/analyzer_cli/lib/src/driver.dart	View	7 chunks	+39 lines, -8 lines	0 comments	Download
M	pkg/analyzer_cli/lib/src/options.dart	View	2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scheglov

3 years, 11 months ago (2017-01-26 18:17:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a3cc5fe7f79fc3a2a896f95ab308e0f0319d3851 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages