Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h

Issue 2657863004: Move scroll paint property nodes to be owned by the transform tree (Closed)
Patch Set: Rebase & remove parens Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h
diff --git a/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h b/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h
index d99b0b1ad4ac6b9ce4b18228c2d2fe9cb4e3fe76..c27d1fd5faf1a739f3188e49da63934e16b96caf 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h
+++ b/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h
@@ -7,7 +7,6 @@
#include "platform/graphics/paint/ClipPaintPropertyNode.h"
#include "platform/graphics/paint/EffectPaintPropertyNode.h"
-#include "platform/graphics/paint/ScrollPaintPropertyNode.h"
#include "platform/graphics/paint/TransformPaintPropertyNode.h"
#include "wtf/HashFunctions.h"
#include "wtf/HashTraits.h"
@@ -23,16 +22,11 @@ class PLATFORM_EXPORT PropertyTreeState {
public:
PropertyTreeState(const TransformPaintPropertyNode* transform,
const ClipPaintPropertyNode* clip,
- const EffectPaintPropertyNode* effect,
- const ScrollPaintPropertyNode* scroll)
- : m_transform(transform),
- m_clip(clip),
- m_effect(effect),
- m_scroll(scroll) {
+ const EffectPaintPropertyNode* effect)
+ : m_transform(transform), m_clip(clip), m_effect(effect) {
DCHECK(!m_transform || !m_transform->hasOneRef());
DCHECK(!m_clip || !m_clip->hasOneRef());
DCHECK(!m_effect || !m_effect->hasOneRef());
- DCHECK(!m_scroll || !m_scroll->hasOneRef());
}
bool hasDirectCompositingReasons() const;
@@ -61,17 +55,9 @@ class PLATFORM_EXPORT PropertyTreeState {
m_effect = std::move(node);
}
- const ScrollPaintPropertyNode* scroll() const {
- DCHECK(!m_scroll || !m_scroll->hasOneRef());
- return m_scroll.get();
- }
- void setScroll(RefPtr<const ScrollPaintPropertyNode> node) {
- m_scroll = std::move(node);
- }
-
- // Returns the compositor element id, if any, for this property state. If none
- // of the scroll, effect or transform nodes for this state have a compositor
- // element id then a default instance is returned.
+ // Returns the compositor element id, if any, for this property state. If
+ // neither the effect nor transform nodes have a compositor element id then a
+ // default instance is returned.
const CompositorElementId compositorElementId() const;
enum InnermostNode {
@@ -127,13 +113,11 @@ class PLATFORM_EXPORT PropertyTreeState {
RefPtr<const TransformPaintPropertyNode> m_transform;
RefPtr<const ClipPaintPropertyNode> m_clip;
RefPtr<const EffectPaintPropertyNode> m_effect;
- // TODO(pdr): Remove the scroll node from PropertyTreeState.
- RefPtr<const ScrollPaintPropertyNode> m_scroll;
};
inline bool operator==(const PropertyTreeState& a, const PropertyTreeState& b) {
return a.transform() == b.transform() && a.clip() == b.clip() &&
- a.effect() == b.effect() && a.scroll() == b.scroll();
+ a.effect() == b.effect();
}
// Iterates over the sequence transforms, clips and effects for a

Powered by Google App Engine
This is Rietveld 408576698