Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: third_party/WebKit/Source/core/paint/BlockPainter.cpp

Issue 2657863004: Move scroll paint property nodes to be owned by the transform tree (Closed)
Patch Set: Rebase & remove parens Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/BlockPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/BlockPainter.cpp b/third_party/WebKit/Source/core/paint/BlockPainter.cpp
index c075bb176cd19ad07535c77fd724ff4eb0ae1d1a..067bd04ec12741d3effb1e61a3e8b696866663e1 100644
--- a/third_party/WebKit/Source/core/paint/BlockPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/BlockPainter.cpp
@@ -202,14 +202,12 @@ void BlockPainter::paintObject(const PaintInfo& paintInfo,
Optional<PaintInfo> scrolledPaintInfo;
if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
const auto* objectProperties = m_layoutBlock.paintProperties();
- if (auto* scroll =
- objectProperties ? objectProperties->scroll() : nullptr) {
+ auto* scrollTranslation =
+ objectProperties ? objectProperties->scrollTranslation() : nullptr;
+ if (scrollTranslation) {
PaintChunkProperties properties(paintInfo.context.getPaintController()
.currentPaintChunkProperties());
- auto* scrollTranslation = objectProperties->scrollTranslation();
- DCHECK(scrollTranslation);
properties.propertyTreeState.setTransform(scrollTranslation);
- properties.propertyTreeState.setScroll(scroll);
m_scopedScrollProperty.emplace(
paintInfo.context.getPaintController(), m_layoutBlock,
DisplayItem::paintPhaseToDrawingType(paintPhase), properties);
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/paint/FindPropertiesNeedingUpdate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698