Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp

Issue 2657863004: Move scroll paint property nodes to be owned by the transform tree (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp b/third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp
index 8bb3ea12991bb8cd19a38bda495a93b2b069a549..7dfd6d2389cc8972ecb48fe3816b161357cae966 100644
--- a/third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp
@@ -228,7 +228,9 @@ TEST_P(PaintControllerPaintTestForSlimmingPaintV2, ChunkIdClientCacheFlag) {
}
const PaintChunk& backgroundChunk = rootPaintController().paintChunks()[0];
- EXPECT_TRUE(backgroundChunk.properties.propertyTreeState.scroll()->isRoot());
+ EXPECT_EQ(
+ nullptr,
chrishtr 2017/01/26 21:22:58 Not sentinel scroll root?
pdr. 2017/01/27 20:09:32 This is really just an overzealous check that the
+ backgroundChunk.properties.propertyTreeState.transform()->scrollNode());
const EffectPaintPropertyNode* effectNode = div.paintProperties()->effect();
EXPECT_EQ(0.5f, effectNode->opacity());

Powered by Google App Engine
This is Rietveld 408576698