third_party/WebKit/Source/core/paint/ObjectPaintProperties.cpp - Issue 2657863004: Move scroll paint property nodes to be owned by the transform tree

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/paint/ObjectPaintProperties.cpp

Issue 2657863004: Move scroll paint property nodes to be owned by the transform tree (Closed)

Patch Set: Rebase & remove parens Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/ObjectPaintProperties.h ('k') | third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "core/paint/ObjectPaintProperties.h"	5 #include "core/paint/ObjectPaintProperties.h"

6	6

7 namespace blink {	7 namespace blink {

8	8

9 void ObjectPaintProperties::updateContentsProperties() const {	9 void ObjectPaintProperties::updateContentsProperties() const {

10 DCHECK(m_localBorderBoxProperties);	10 DCHECK(m_localBorderBoxProperties);

11 DCHECK(!m_contentsProperties);	11 DCHECK(!m_contentsProperties);

12	12

13 m_contentsProperties =	13 m_contentsProperties =

14 WTF::makeUnique<PropertyTreeState>(*m_localBorderBoxProperties);	14 WTF::makeUnique<PropertyTreeState>(*m_localBorderBoxProperties);

15	15

16 if (scrollTranslation())	16 if (scrollTranslation())

17 m_contentsProperties->setTransform(scrollTranslation());	17 m_contentsProperties->setTransform(scrollTranslation());

18

19 if (scroll())

20 m_contentsProperties->setScroll(scroll());

21

22 if (overflowClip())	18 if (overflowClip())

23 m_contentsProperties->setClip(overflowClip());	19 m_contentsProperties->setClip(overflowClip());

24 else if (cssClip())	20 else if (cssClip())

25 m_contentsProperties->setClip(cssClip());	21 m_contentsProperties->setClip(cssClip());

26	22

27 // TODO(chrishtr): cssClipFixedPosition needs to be handled somehow.	23 // TODO(chrishtr): cssClipFixedPosition needs to be handled somehow.

28 }	24 }

29	25

30 } // namespace blink	26 } // namespace blink

OLD	NEW