Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2657863004: Move scroll paint property nodes to be owned by the transform tree (Closed)
Patch Set: Rebase & remove parens Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights
8 reserved. 8 reserved.
9 9
10 This library is free software; you can redistribute it and/or 10 This library is free software; you can redistribute it and/or
(...skipping 696 matching lines...) Expand 10 before | Expand all | Expand 10 after
707 } 707 }
708 708
709 void setScrollTranslation( 709 void setScrollTranslation(
710 PassRefPtr<TransformPaintPropertyNode> scrollTranslation) { 710 PassRefPtr<TransformPaintPropertyNode> scrollTranslation) {
711 m_scrollTranslation = scrollTranslation; 711 m_scrollTranslation = scrollTranslation;
712 } 712 }
713 TransformPaintPropertyNode* scrollTranslation() const { 713 TransformPaintPropertyNode* scrollTranslation() const {
714 return m_scrollTranslation.get(); 714 return m_scrollTranslation.get();
715 } 715 }
716 716
717 void setScroll(PassRefPtr<ScrollPaintPropertyNode> scroll) {
718 m_scroll = scroll;
719 }
720 ScrollPaintPropertyNode* scroll() const { return m_scroll.get(); }
721
722 void setContentClip(PassRefPtr<ClipPaintPropertyNode> contentClip) { 717 void setContentClip(PassRefPtr<ClipPaintPropertyNode> contentClip) {
723 m_contentClip = contentClip; 718 m_contentClip = contentClip;
724 } 719 }
725 ClipPaintPropertyNode* contentClip() const { return m_contentClip.get(); } 720 ClipPaintPropertyNode* contentClip() const { return m_contentClip.get(); }
726 721
727 // The property tree state that should be used for painting contents. These 722 // The property tree state that should be used for painting contents. These
728 // properties are either created by this FrameView or are inherited from 723 // properties are either created by this FrameView or are inherited from
729 // an ancestor. 724 // an ancestor.
730 void setTotalPropertyTreeStateForContents( 725 void setTotalPropertyTreeStateForContents(
731 std::unique_ptr<PropertyTreeState> state) { 726 std::unique_ptr<PropertyTreeState> state) {
(...skipping 412 matching lines...) Expand 10 before | Expand all | Expand 10 after
1144 1139
1145 // Paint properties for SPv2 Only. 1140 // Paint properties for SPv2 Only.
1146 // The hierarchy of transform subtree created by a FrameView. 1141 // The hierarchy of transform subtree created by a FrameView.
1147 // [ preTranslation ] The offset from Widget::frameRect. 1142 // [ preTranslation ] The offset from Widget::frameRect.
1148 // | Establishes viewport. 1143 // | Establishes viewport.
1149 // +---[ scrollTranslation ] Frame scrolling. 1144 // +---[ scrollTranslation ] Frame scrolling.
1150 // TODO(trchen): These will not be needed once settings->rootLayerScrolls() is 1145 // TODO(trchen): These will not be needed once settings->rootLayerScrolls() is
1151 // enabled. 1146 // enabled.
1152 RefPtr<TransformPaintPropertyNode> m_preTranslation; 1147 RefPtr<TransformPaintPropertyNode> m_preTranslation;
1153 RefPtr<TransformPaintPropertyNode> m_scrollTranslation; 1148 RefPtr<TransformPaintPropertyNode> m_scrollTranslation;
1154 RefPtr<ScrollPaintPropertyNode> m_scroll;
1155 // The content clip clips the document (= LayoutView) but not the scrollbars. 1149 // The content clip clips the document (= LayoutView) but not the scrollbars.
1156 // TODO(trchen): This will not be needed once settings->rootLayerScrolls() is 1150 // TODO(trchen): This will not be needed once settings->rootLayerScrolls() is
1157 // enabled. 1151 // enabled.
1158 RefPtr<ClipPaintPropertyNode> m_contentClip; 1152 RefPtr<ClipPaintPropertyNode> m_contentClip;
1159 // The property tree state that should be used for painting contents. These 1153 // The property tree state that should be used for painting contents. These
1160 // properties are either created by this FrameView or are inherited from 1154 // properties are either created by this FrameView or are inherited from
1161 // an ancestor. 1155 // an ancestor.
1162 std::unique_ptr<PropertyTreeState> m_totalPropertyTreeStateForContents; 1156 std::unique_ptr<PropertyTreeState> m_totalPropertyTreeStateForContents;
1163 // Whether the paint properties need to be updated. For more details, see 1157 // Whether the paint properties need to be updated. For more details, see
1164 // FrameView::needsPaintPropertyUpdate(). 1158 // FrameView::needsPaintPropertyUpdate().
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
1241 widget.isFrameView()); 1235 widget.isFrameView());
1242 DEFINE_TYPE_CASTS(FrameView, 1236 DEFINE_TYPE_CASTS(FrameView,
1243 ScrollableArea, 1237 ScrollableArea,
1244 scrollableArea, 1238 scrollableArea,
1245 scrollableArea->isFrameView(), 1239 scrollableArea->isFrameView(),
1246 scrollableArea.isFrameView()); 1240 scrollableArea.isFrameView());
1247 1241
1248 } // namespace blink 1242 } // namespace blink
1249 1243
1250 #endif // FrameView_h 1244 #endif // FrameView_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698