Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Side by Side Diff: third_party/WebKit/Source/core/paint/FramePainter.cpp

Issue 2657863004: Move scroll paint property nodes to be owned by the transform tree (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/paint/FramePainter.h" 5 #include "core/paint/FramePainter.h"
6 6
7 #include "core/editing/markers/DocumentMarkerController.h" 7 #include "core/editing/markers/DocumentMarkerController.h"
8 #include "core/frame/FrameView.h" 8 #include "core/frame/FrameView.h"
9 #include "core/inspector/InspectorInstrumentation.h" 9 #include "core/inspector/InspectorInstrumentation.h"
10 #include "core/inspector/InspectorTraceEvents.h" 10 #include "core/inspector/InspectorTraceEvents.h"
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 // The scrollbar's property nodes are similar to the frame view's 96 // The scrollbar's property nodes are similar to the frame view's
97 // contents state but we want to exclude the content-specific 97 // contents state but we want to exclude the content-specific
98 // properties. This prevents the scrollbars from scrolling, for example. 98 // properties. This prevents the scrollbars from scrolling, for example.
99 PaintChunkProperties properties( 99 PaintChunkProperties properties(
100 context.getPaintController().currentPaintChunkProperties()); 100 context.getPaintController().currentPaintChunkProperties());
101 properties.propertyTreeState.setTransform( 101 properties.propertyTreeState.setTransform(
102 m_frameView->preTranslation()); 102 m_frameView->preTranslation());
103 properties.propertyTreeState.setClip( 103 properties.propertyTreeState.setClip(
104 m_frameView->contentClip()->parent()); 104 m_frameView->contentClip()->parent());
105 properties.propertyTreeState.setEffect(contentsState->effect()); 105 properties.propertyTreeState.setEffect(contentsState->effect());
106 auto* scrollBarScroll = contentsState->scroll();
107 if (m_frameView->scroll())
108 scrollBarScroll = m_frameView->scroll()->parent();
109 properties.propertyTreeState.setScroll(scrollBarScroll);
chrishtr 2017/01/26 21:22:58 Did this functionality get replaced?
pdr. 2017/01/27 20:09:32 This shouldn't have been used. It was for painting
110 scopedPaintChunkProperties.emplace(context.getPaintController(), 106 scopedPaintChunkProperties.emplace(context.getPaintController(),
111 *frameView().layoutView(), 107 *frameView().layoutView(),
112 properties); 108 properties);
113 } 109 }
114 } 110 }
115 111
116 TransformRecorder transformRecorder( 112 TransformRecorder transformRecorder(
117 context, *frameView().layoutView(), 113 context, *frameView().layoutView(),
118 AffineTransform::translation(frameView().x(), frameView().y())); 114 AffineTransform::translation(frameView().x(), frameView().y()));
119 115
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 246
251 bar.paint(context, CullRect(rect)); 247 bar.paint(context, CullRect(rect));
252 } 248 }
253 249
254 const FrameView& FramePainter::frameView() { 250 const FrameView& FramePainter::frameView() {
255 DCHECK(m_frameView); 251 DCHECK(m_frameView);
256 return *m_frameView; 252 return *m_frameView;
257 } 253 }
258 254
259 } // namespace blink 255 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698